Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
in uc_taxes.js, l. 47 :
" for (j in taxes) {"
If for some reason taxes get methods attached to it, the function getTax won't work and this section of the check out page (payment method -> Order total preview:) will loop for ever.
I have added l.48 :
" if(!isNaN(j)) {"
But there is maybe a better method...
Comment | File | Size | Author |
---|---|---|---|
#3 | ubercart-n646660.patch | 3.55 KB | DamienMcKenna |
Comments
Comment #1
DamienMcKennaAm seeing this exact problem. It's related to #629964: Patch to Cut Down on Tax Calculation Ajax Calls on Checkout Form and #684552: Payment summary never loads in IE (Checkout) -- but in FF.
Comment #2
DamienMcKennaFYI this uc_taxes.js adds:
This then gets triggered by render_line_items() in uc_payment.js from the following line:
This gets triggered by set_line_item() which gets triggered on pageload by this line in uc_order.line_item.inc:
I'm surprised more people aren't complaining.
Comment #3
DamienMcKennaHere's a patch that checks to see if the return from the AJAX call is empty before running the logic from the 'success' callback.
Comment #4
DamienMcKennaFYI I added a pagebreak on this line in both Firefox 3.6 and Safari 5.0.1:
The breakpoint never triggers in Firefox but it does in Safari. When I inspect the 'taxes' variable in Safari it says:
with __proto__ listing a whole bunch of functions.
Comment #5
longwaveThis seems to have been fixed by #684552: Payment summary never loads in IE (Checkout) -- but in FF, please reopen if there are other problems in uc_taxes.js.
Comment #7
chris_getdepth CreditAttribution: chris_getdepth commentedgreetings
a site i have built with ubercart 6.x-2.4 installed has suddenly started to experience this problem.
when you go to the checkout page the payment method never loads, and the webhost blocks my ip.
the latest site log entries all say:
so i am guessing the uc_tax_module and more likely the uc_tax.js is causing the problem.
i have read through
#629964: Patch to Cut Down on Tax Calculation Ajax Calls on Checkout Form
and applied patch #11
as well as
#684552: Payment summary never loads in IE (Checkout) -- but in FF
and applied patch #47
but neither have solved the issue either individually nor together
the site uses the uc_vat module too and i have found the thread #1091440: Endless progress bar loading in checkout form on cart/checkout page when tax 0% is set but the tax is not set to 0% so i guess it isn't that either. (though i have tried the patch #2 but it did not solve this either).
the site is also experiencing the issue described by #766530: Review order button loop back to the cart checkout page! however although it gets redirect to the checkout page it actually throws a 404 page not found so i am guessing that that too might be being caused by this uc_taxes issue.
(apologies if i should have posted in one of those other threads - i just figured this one was the one with the most recent activity)
help with this would be greatly appreciated!
thanks in advance
Comment #8
chris_getdepth CreditAttribution: chris_getdepth commented(just changing the priority and status as i somehow managed to set a different thread's no this one, tut!)
Comment #9
TR CreditAttribution: TR commentedThis issue and the others you cited have been fixed already in 6.x-2.x-dev. Please upgrade to the -dev release, and if you are still having problems then open a new issue describing the problems. It would be helpful if you included a link to your site.
Comment #10
chris_getdepth CreditAttribution: chris_getdepth commentedaha ok i didnt realise it had been commited to the dev release - however i dont tend to use dev releases on live sites. i'll upgrade and see if that fixes it.
like i said apologies for cross posting the issue here but it seemed relevent and i didnt want to duplicate the issue.
many thanks
* Update - just to let you know that installing 6.x-2.x-dev did indeed solve this issue. thanks TR for the info.