Closed (won't fix)
Project:
Inline
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 May 2006 at 13:33 UTC
Updated:
2 Mar 2007 at 17:24 UTC
inline does not make difference beetween inline, file or attachment tags.
if I use [inline:myfile.png] or [inline:myfile.png] or [inline:myfile.png], the returned html code is always:
<a href="http://www.myservezr.com/files/myfile.png" title="View: ">
<img style="" src="http://www.myservezr.com/files/myfile.png" class="inline" alt="myfile.png" title="myfile.png">
</a>
Comments
Comment #1
sunNot a bug, these are just synonyms. If you're looking for additional support for the attachment module you might test this patch.
Comment #2
pitpit commentedok, thx for your answer.
Comment #3
awgrover commentedFrom the README:
"When dealing with images, they will be shown inline only if you use
'inline' syntax; any other syntax will print a text link to the file."
I chose to believe this, and so fixed it. The following patch "inlines" images only if you use the syntax "inline":
--- /var/www/html/drupal-5.1/scripts/.cache/projects/inline/inline.module 2007-02-23 14:04:59.000000000 -0600
+++ inline.module 2007-03-02 08:23:20.000000000 -0600
@@ -283,7 +283,7 @@
$replace = "";
if ($file->fid != NULL) {
//decide if we should show a link or an img tag
- if (_inline_decide_img_tag($file)) {
+ if ($match[1][$key] == 'inline' && _inline_decide_img_tag($file)) {
$replace = theme('inline_img', $file);
}
else {
Comment #4
awgrover commentedComment #5
sunThe usage of three different tags, in particular the usage of
[attachment]and[file], is deprecated. It won't be supported anymore in one of the next releases.