Issue link: http://drupal.org/node/224333#absolute_includes

CommentFileSizeAuthor
#3 absolute-path-642992.patch1.89 KBbabbage

Comments

babbage’s picture

babbage commented
Assigned: Unassigned » babbage

Have a patch for this. Testing it, and expect to upload it tomorrow.

babbage’s picture

babbage commented
Issue tags: +DrupalSouth

Added tags. Working on Coder Upgrade patches at the DrupalSouth hackfest, at the behest of webchick. :)

babbage’s picture

babbage commented
Status: Active » Needs review
StatusFileSize
new absolute-path-642992.patch1.89 KB

Patch attached. Original regex for this issue in Coding Review didn't actually work. The attached patch both corrects that regex, ensures that a warning is not given in situations where the user has already made this upgrade, and adds an automatic upgrade where it is required.

solotandem’s picture

solotandem commented
Status: Needs review » Fixed

Fixed in next dev release.

dbabbage, thank you for the patch. I implemented this upgrade using the grammar parser, as it is preferred over regular expressions. See coder_upgrade_upgrade_call_alter() in the file coder_upgrade.call.inc.

Correction to review rule still needs to be committed. Added #727724: Use absolute path (constructed from DRUPAL_ROOT) when including a file for the review rule change.

Status: Fixed » Closed (fixed)
Issue tags: -Intermediate, -DrupalSouth

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Intermediate, +DrupalSouth

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.