Closed (fixed)
Project:
Admin role
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Nov 2009 at 02:45 UTC
Updated:
11 Dec 2009 at 05:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
dave reidAttached is the simle adminrole.install file that I'm using on my production sites that removes a step that I had to perform manually.
Comment #2
dave reidComment #3
Bevan commentedI didn't apply or test functionality yet (I trust you have), but here are some notes;
We need a
@fileheader.We should add
hook_uninstall()if we are adding ahook_install().I'm not sure this is a good idea, since it might be a security vulnerability (for existing sites). Maybe we should also check that the role has certain permissions like "administer site configuration".
Maybe we should also check for roles like 'admin', and possibly others? E.g.
WHERE name IN ('admin', 'administrator').At the end we need adminrole module to do it's thing – set all permissions for that role.
This review is powered by Dreditor.
Comment #4
dave reidYeah I'm seeing a point that we shouldn't do anything if there is a role name that starts with 'admin' since they might have already started using proper permissions. Committed a modified version of the patch to CVS.
Comment #5
Bevan commentedPlease upload the patch here and link to the CVS commit message/page; one of these; http://drupal.org/project/cvs/128621
Thanks!
Comment #6
dave reidSorry, I already deleted the patch files I had made.
CVS commit for 6.x: http://drupal.org/cvs?commit=293940
CVS commit for 5.x: http://drupal.org/cvs?commit=293942