I'd like to ask if the maintainer wish to see a full module code style review based on core rules?

Comments

MGN’s picture

MGN CreditAttribution: MGN commented
Category: bug » task

I am not entirely sure what this means, but it sounds good. Sounds more like a task than a bug report. Any contribution is appreciated.

hass’s picture

hass CreditAttribution: hass commented

e.g. Core style:

  $form['settings'] = array(
    '#type' => 'fieldset',
    '#title' => t('Basic settings'),
    '#collapsible' => TRUE,
  );

But I do not like to waste my time if you may refuse such style changes.

MGN’s picture

MGN CreditAttribution: MGN commented

Of course. If you want to submit a patch that uniformly fixes the code style I will be happy to commit it! Thanks again.

Haza’s picture

Haza
Primary language French
CreditAttribution: Haza commented
Status: Active » Closed (won't fix)

I think we'll never see that patch.

BTW, I made a quick review on the 7.x branch, it seems pretty fine, so closing this one.

hass’s picture

hass CreditAttribution: hass commented
Status: Closed (won't fix) » Active

You can also run coder and do the changes if you find the time... there are some things to fix.

Haza’s picture

Haza
Primary language French
CreditAttribution: Haza commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

At least let's do that for the 7.x branch.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle at Hannemyr Nye Medier AS commented
Issue summary: View changes
Status: Active » Closed (outdated)

Eight years has passed without any further comments. Closing this as outdated. If you think this is still relevant for Drupal 7 or Drupal 9, please open a new issue.