Can you please remove the 'e' from this error message:

"Failed on MySQL 5.0 ISAM, with: 15,186 pass(es), 19 fail(s), and 17 exception(es)."

CommentFileSizeAuthor
#6 639232-summary-message.patch583 byteswebchick
#3 639232-summary-message.patch983 bytesboombatower

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

In fact, why not format_plural so such language hacks weren't necessary?

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Postponed (maintainer needs more info)

My reason for not using format_plural() in the first place was that I don't see how it can be used with three count arguments unless I am to format each part separately and then merge them together.

t('@pass, @fail, and @exception', array('@pass' => format_plural()...)

That seemed like overkill at the time, but is that what we want?

boombatower’s picture

boombatower commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 639232-summary-message.patch983 bytes

Talked with webchick, we'll just go with removing the 'e' for now.

boombatower’s picture

boombatower commented
Title: There is no such word as "exceptiones" » Change '(es)' to '(e)' in summary message
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Closed (fixed) » Reviewed & tested by the community
StatusFileSize
new 639232-summary-message.patch583 bytes

Hm. It looks like this never got committed, or at least not to the branch that qa.d.o is using.

Here's a re-rolled patch against 6.x-2.x. I can haz? :)

jthorson’s picture

jthorson commented
Status: Reviewed & tested by the community » Fixed

Committed to 6.x-2.x (1531999).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.