On admin/settings/taxonomy-breadcrumb the radios Include or exclude the following node types: don't have a default selection on brand new installations. None of the radios is marked as selected.

What should be the default setting?

CommentFileSizeAuthor
#8 taxonomy_breadcrumb_bug2.patch2.89 KBhass
#1 taxonomy_breadcrumb_bug1.patch1.94 KBhass

Comments

hass’s picture

hass commented
Version: 6.x-1.0 » 6.x-1.x-dev
Status: Active » Reviewed & tested by the community
StatusFileSize
new taxonomy_breadcrumb_bug1.patch1.94 KB

Bugfix attached.

Only as a side note - module releases in 6.x-1.x need to start with 61xx.

MGN’s picture

MGN commented
Status: Reviewed & tested by the community » Closed (works as designed)

This is by design. The admin has to select, since there is no obvious default. It will vary from site to site. Its better to leave it as it is, with everything false, so there are no intended consequences.

Perhaps this needs to be better documented.

hass’s picture

hass commented
Status: Closed (works as designed) » Reviewed & tested by the community

No. Radio options does not allow keys with false and true. If you need a screenshot...

MGN’s picture

MGN commented

Ok. I see what you mean. I'll roll this in with the next round of updates.

MGN’s picture

MGN commented

I agree with the changes in taxonomy_breadcrumb.admin.inc (basically changing FALSE to 0 and TRUE to 1), but I am not sure the hook_update is really needed since there are no database changes that need to be made. I haven't noticed any problems without it.

hass’s picture

hass commented

I thought this first, too. But nevertheless I've seen in variable table a saved serialized value of b:0 the radio with key 0 wasn't selected. Therefore this is an upgrade path for all who have a serialized boolean value of 0 in their database. I believe this have something to do with form API, but you cannot really see the issue if you have a boolean of 1 in the DB. Why - I don't know - but this upgrade hook brings all users to the same values with integer 1 or 0 and should therefore more painless than everything else.

It has been tested in several ways :-).

hass’s picture

hass commented

Aside - I missed one line in the .module file - FALSE need to become 0 here, too.

if ($in_list == variable_get('taxonomy_breadcrumb_include_nodes', FALSE) ) {
hass’s picture

hass commented
StatusFileSize
new taxonomy_breadcrumb_bug2.patch2.89 KB

Updated patch attached.

MGN’s picture

MGN commented
Status: Reviewed & tested by the community » Fixed

Thanks. Committed to 6.x-1.x-dev.

hass’s picture

hass commented

thx

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.