Replace hook_user_view() with hook_menu_local_tasks_alter() [#638422]

#542658: Move action "tabs" out of local tasks over the core issue introducing this option.

Also, the hook_user_view should probably be replaced by hook_menu_local_tasks_alter? (there is a patch in at #542658-72: Move action "tabs" out of local tasks which shows how it is done for other core modules.)

Set to task as this is just a reminder/discussion point so far, especially to the replacement for the user vew pages.

Comment	File	Size	Author
#3	local_action2.patch	7.35 KB	berdir
#2	local_action.patch	1.38 KB	berdir

Comments

Comment #1

berdir

German

Switzerland

commented 7 December 2009 at 19:15

Had a look at this, attached a first patch (Only messages/new is implemented)

The issue is that it works by default only on /messages and not on /messages/inbox and so on. This can be fixed by adding a privatemsg_menu_local_tasks_alter() hook but the question is if we really want to display it on all pages below messages/ (including read and so on)...

Also, the look is imho not that great in Garland (It looks better in Seven with the + symbol).

Comment #2

berdir

German

Switzerland

commented 7 December 2009 at 19:16

Status:

Active

» Needs review

Status	File	Size
new	local_action.patch	1.38 KB

Erm...

Comment #3

berdir

German

Switzerland

commented 20 January 2010 at 16:34

Status	File	Size
new	local_action2.patch	7.35 KB

Found out that I don't need that hook, that's just necessary when you want to display the action somewhere else than in the default path.

The updated patch also converts the Add Tag link, removes the now unecessary default local task list and fixes a few broken links which I've forgot to change in the admin area. That would have even caught by the tests, but if I don't run them... :)