Found this module very useful for my projects and used it today the first time. As it was very small I's like to provide a German translation very soon. Before I provide any translation I'm mostly doing translatable string reviews...

Therefore I've done a full code review as the module wasn't that big... and fixed all code style issues, translatable string bugs and fixed SQL code style bugs plus a hook_help bug and so on... this patch touches many lines, but this is often only a missing blank and some things that make code more speedy and more specific (hook_preprocess_page and hook_form_FORM_ID_alter) as we know them and there is no need to fire on all available forms and preprocess hooks.

Code wise it should all be ok, I will do a test tomorrow on my DEV site.

Comments

hass’s picture

Fixed a missing bracket.

hass’s picture

Looks like there is no need to check_plain the title. Removed the check_plain.

hass’s picture

New patch. This one also fixes the bug that the title field is shown on the term delete page.

jenlampton’s picture

Status: Needs review » Fixed

@hass, thanks for all your work on this, I look forward to receiving your translation :-)
Committed to dev branch, new release shortly.
Jen

hass’s picture

Version: 6.x-1.1 » 6.x-1.2
Status: Fixed » Active

It looks like my fixes are not in 1.2

hass’s picture

Status: Active » Needs review
hass’s picture

New patch attached. Please give me some time to update the translation file after the commit and before the next release.

http://drupal.org/coding-standards
http://drupal.org/project/coder

jenlampton’s picture

Status: Needs review » Active

Ok, committed the new patch, but may issue a new release for two other critical issues.

hass’s picture

What else is broken?

hass’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.