Closed (fixed)
Project:
Notifications Add-ons
Version:
6.x-2.0-beta2
Component:
Custom subscriptions
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Nov 2009 at 03:56 UTC
Updated:
23 Jul 2010 at 15:50 UTC
Hi,
When using Postgres 8.1, I'm unable to create any custom subscriptions.
admin/messaging/customsubs/new
I filled out the required fields with "test", and saved the form. The resulting page had an error:
* warning: pg_query() [function.pg-query]: Query failed: ERROR: null value in column "module" violates not-null constraint in /vhost/php/drupal_6_9/includes/database.pgsql.inc on line 139.
* user warning: query: INSERT INTO notifications_custom (type, title, name, description, event_type, weight, required, register, visibility, default_value) VALUES ('custom_test', 'Test', 'Test', '', 'node', 0, 0, 0, 0, 0) in /vhost/php/drupal_6_9/includes/common.inc on line 3425.
The custom subscription fails to save.
It seems there isn't a value being stored in the module column. Not sure if there SHOULD be something saved...
Attached is a patch to set a default to the module column. I've tested it an it seems to work well after this, with subscriptions being saved correctly.
Michael
| Comment | File | Size | Author |
|---|---|---|---|
| notifications_extra-postgres.patch | 930 bytes | maikeru |
Comments
Comment #1
maikeru commentedComment #2
danepowell commentedThis looks reasonable - can someone else (preferably using Postgres) please test the patch and report back?
Comment #3
jose reyero commentedThis looks good to me, applied to 4.x
(I don't use pgsql either so I'm happy enough if it doesn't break mysql)
Comment #4
danepowell commented