Time format is hard coded in order comments [#632882]

Time of order comments is hardcoded to "g:i:s A" in functions op_order_comments_view_table and op_admin_comments_view_table, in uc_order.order_pane.inc.

This gives incorrect display for countries that are not using US time format.

Correct solutions would be to add a time format in UC settings, or to use the date_format_short value from Drupal settings, and replace the dash with line a break.

Since there is an Ubercart setting for date format, I think that first solution is better.

      $data['date'] = array(
        '#value' => format_date(
          $comment->created, 
          'custom', 
          variable_get('uc_date_format_default', 'm/d/Y') .'<\b\r />g:i:s A'),
        '#cell_attributes' => array('align' => 'center', 'nowrap' => 'true'),
      );

      $data['date'] = array(
        '#value' => format_date(
          $comment->created, 
          'custom', 
          variable_get('uc_date_format_default', 'm/d/Y') .'<\b\r />'. variable_get('uc_time_format_default', 'g:i:s A')),
        '#cell_attributes' => array('align' => 'center', 'nowrap' => 'true'),
      );

Comments

Comment #1

flebas CreditAttribution: flebas commented 19 November 2009 at 00:44

Category:

feature

» bug

Changed category to bug report.

Comment #2

TR CreditAttribution: TR commented 21 February 2010 at 01:55

Can you turn this into a patch so others can test it?

Comment #3

TR CreditAttribution: TR commented 27 February 2010 at 18:54

Issue tags:

+Ubercart theme layer

Tagging

Comment #4

eliosh

He, Him

Italian

Bacoli

CreditAttribution: eliosh commented 18 January 2011 at 12:59

You can also use hook_tapir_table_alter in a custom module:


function CUSTOMMODULE_tapir_table_alter(&$table, $table_id) {
  if ($table_id == 'op_order_comments_view_table') {
    $comments = $table['#parameters'][1];
    $table['#rows'] = array();
    if (is_array($comments)) {
      foreach ($comments as $comment) {
        $data = array();
        $data['date'] = array(
          '#value' => format_date($comment->created, 'custom', variable_get('uc_date_format_default', 'm/d/Y') .'<\b\r />H:i:s'),
          '#cell_attributes' => array('align' => 'center', 'nowrap' => 'true'),
        );
        $data['user'] = array(
          '#value' => uc_get_initials($comment->uid),
          '#cell_attributes' => array('align' => 'center'),
        );
        $data['notified'] = array(
          '#value' => (($comment->notified == 1)
            ? '<img src="'. base_path() . drupal_get_path('module', 'uc_order') .'/images/true-icon.gif" />'
            : '<img src="'. base_path() . drupal_get_path('module', 'uc_order') .'/images/false-icon.gif" />'),
          '#cell_attributes' => array('align' => 'center'),
        );
        $data['status'] = array(
          '#value' => $comment->title,
          '#cell_attributes' => array('align' => 'center'),
        );
        $data['comment'] = array(
          '#value' => filter_xss_admin($comment->message),
        );
        $table['#rows'][] = $data;
      }
    }
    else {
      $data['comment'] = array(
        '#value' => t('This order has no comments associated with it.'),
        '#cell_attributes' => array('colspan' => 'full'),
      );
      $table['#rows'][] = $data;
    }

  }
}

Comment #5

TR CreditAttribution: TR commented 4 April 2011 at 04:51

Version:

6.x-2.x-dev

» 7.x-3.x-dev

Moving to 7.x-3.x.

Comment #6

Island Usurper CreditAttribution: Island Usurper commented 21 April 2011 at 21:02

Do we really even need that <br /> in that particular cell? Someone ought to see if word wrapping handles that well enough to begin with. Then we can just go to the normal short format that Drupal already provides.