drupal_get_query_array() and drupal_http_build_query() are two complementary API functions, but their names give no clue about this. We should have them renamed consistently.

CommentFileSizeAuthor
#5 http_query_string-631852-5.patch10.95 KBpwieck
#1 http_query_string-631852-1.patch7.29 KBplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
StatusFileSize
new http_query_string-631852-1.patch7.29 KB

The attached patch renames drupal_get_query_array() and drupal_http_build_query() to drupal_http_query_split() and drupal_http_query()_build.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Issue tags: +API clean-up
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Version: 7.x-dev » 8.x-dev

Spoke with webchick about this.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

Patch does not apply anymore.

pwieck’s picture

pwieck commented
Status: Needs work » Needs review
StatusFileSize
new http_query_string-631852-5.patch10.95 KB

I tried to redo this using fresh build from today.

Status: Needs review » Needs work
Issue tags: -API clean-up

The last submitted patch, http_query_string-631852-5.patch, failed testing.

pwieck’s picture

pwieck commented
Status: Needs work » Needs review
Issue tags: +API clean-up

#5: http_query_string-631852-5.patch queued for re-testing.

pwieck’s picture

pwieck commented

Is it normal for the testbot to fail a test the 1st time around? I'm new at this and this is the second time I had a test pass not until re-test.

Hope this helps someone.

alansaviolobo’s picture

alansaviolobo commented
Version: 8.0.x-dev » 7.x-dev
Issue summary: View changes
Status: Needs review » Needs work

these function don't exist in D8 anymore. this could apply to D7.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

way too late to change this in D7.