Cache rules everything around me.

This is sorta important because if you want to use apachesolr and memcached, the wildcard clearing causes a general cache wipe, and thus a lot of expensive rebuilds.

CommentFileSizeAuthor
#11 apachesolr-cache-table-630798-1-D5.patch6.21 KBclaudiu.cristea
#10 apachesolr-cache-table-630798-D5.patch5.4 KBclaudiu.cristea
#8 cache_apachesolr.patch1.31 KBrobertdouglass
#7 fu-630798-7.patch1.72 KBpwolanin
#5 fu-630798-4-D6.patch2 KBpwolanin
#3 cache_apachesolr.patch1.65 KBrobertdouglass
#1 cache_apachesolr.patch2.98 KBrobertdouglass
apachesolr_cache.patch3.39 KBjoshk

Comments

robertdouglass’s picture

robertdouglass commented
StatusFileSize
new cache_apachesolr.patch2.98 KB

Just for fun, compare the patch that I made to do the same this morning :)

JacobSingh’s picture

JacobSingh commented
Component: SolrPHP Client » Code

$$bill ya'll :P

I think this is a good commit any objections?

robertdouglass’s picture

robertdouglass commented
Version: 6.x-2.x-dev » 5.x-2.x-dev
Status: Needs review » Patch (to be ported)
StatusFileSize
new cache_apachesolr.patch1.65 KB

Committed to 6.1 and 6.2.

Claudiu, you'll need to edit .install so that it creates the table and does the update.

joshk’s picture

joshk commented

@RobertDouglas: description and default serialization FTW!

pwolanin’s picture

pwolanin commented
StatusFileSize
new fu-630798-4-D6.patch2 KB

I don't think we need to set the serialized value if we are using cache_set() - in fact, doing so seems not to have any effect based on the cache_set() code.

Committing this minor follow-up also to the 6 branches.

pwolanin’s picture

pwolanin commented
Version: 5.x-2.x-dev » 6.x-1.x-dev
Status: Patch (to be ported) » Needs work

argh.

Robert's patch missed changing the calls to cache_get() ...

pwolanin’s picture

pwolanin commented
Priority: Normal » Critical
Status: Needs work » Needs review
StatusFileSize
new fu-630798-7.patch1.72 KB

Follow-up/clean-up

robertdouglass’s picture

robertdouglass commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Priority: Critical » Normal
Status: Needs review » Needs work
StatusFileSize
new cache_apachesolr.patch1.31 KB

Yup, two of them.

robertdouglass’s picture

robertdouglass commented
Version: 6.x-2.x-dev » 5.x-2.x-dev
Status: Needs work » Patch (to be ported)

#630798 by robertDouglass, pwolanin, joshk | JacobSingh: Added Implement cache_apachesolr() table.

Fixed in both 6.x branches.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
StatusFileSize
new apachesolr-cache-table-630798-D5.patch5.4 KB

Here's the patch for DRUPAL-5--2...

I have only one comment: "apachesolr:" should be stripped out from CIDs while we have our own table for caching... Right?

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
StatusFileSize
new apachesolr-cache-table-630798-1-D5.patch6.21 KB

Forgot the CHANGELOG.txt :)

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Patch (to be ported) » Fixed

Committed in #317530.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.