A simple enough change - new messages should now be visually marked by a "new" marker.

(I cannot seem to get wincvs working properly, so this is a manual modification of a directory diff.)

CommentFileSizeAuthor
#4 privatemsg.new_.patch1.15 KBnaheemsays
privatemsg.new_.patch1.14 KBnaheemsays

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Should we use theme_mark() here?

http://api.drupal.org/api/function/theme_mark/6

naheemsays’s picture

naheemsays commented

I was using comment.module as a guide here, but I have no preferences - as long as it is there and in some colour...

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I see. I'm fine with doing it the same way like comment.tpl.php. However, there is a small difference, comment.tpl.php does use drupal_ucfirst() so that you have 'New' instead of 'new'. Should we add that too?

naheemsays’s picture

naheemsays commented
StatusFileSize
new privatemsg.new_.patch1.15 KB

Done

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Added to 6.x-1.x-dev and 7.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.