Views 2.7 breaks views accordion [#621568]

I use views accordion to produce a FAQ page pulling together faqs of type x. My faq view fetches all faq types with term x. All was working. Now I have updated to views 6.x-2.7 the FAQs are all blank. I have the title label but not titles and no bodies. If I change the display to say table then I see the titles and bodies so this would seem to be a change in views, or a bug in views (but I haven't reported it as such yet so I'm not accuse of cross posting).

Comment	File	Size	Author
#3	views_accordion-621568.patch	1.85 KB	Manuel Garcia
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jwilde CreditAttribution: jwilde commented 3 November 2009 at 09:12

Same problem here.

Comment #2

malc_b CreditAttribution: malc_b commented 3 November 2009 at 11:02

I posted on the views about reversing the update as I was stuoopid enough to updpate and not backup (it was late and this wasn't a live site, but it did stop work on the site so almost as bad).

The views people reckon just replacing the views files should be enough to go back. Looking at the update that should only have run 6007, Add aggregate function to PostgreSQ. I'm using mysql so that won't have run past the if pgsql. I've replaced 2.7 views directory with the deleted 2.6 and now views accordion works again. This is a definite bug then.

Comment #3

Manuel Garcia CreditAttribution: Manuel Garcia commented 3 November 2009 at 11:13

Version:	6.x-1.2-rc1	» 6.x-1.x-dev
Assigned:	Unassigned	» Manuel Garcia

File	Size
views_accordion-621568.patch	1.85 KB

Thanks for reporting guys.

Latest views release included some changes to the render() inside views_plugin_style, that we needed to update in views_accordion since we are using our own render function to setup and load our js and settings.

I have commited the fix for this, but since this is critical, please find attached a patch (made against the latest dev version).

I will make another RC release shortly to avoid problems on new installs.

Comment #4

Manuel Garcia CreditAttribution: Manuel Garcia commented 3 November 2009 at 11:13

Status:

Active

» Fixed

Comment #5

Manuel Garcia CreditAttribution: Manuel Garcia commented 3 November 2009 at 11:50

I have now created a new release, please upgrade to RC2

Comment #6

jwilde CreditAttribution: jwilde commented 3 November 2009 at 13:13

Thank you Manuel for fixing this so quickly. I greatly appreciate your time hard work. It works perfectly.

Kind regards,

Jim

Comment #7

CKIDOW

he/his

German

CreditAttribution: CKIDOW commented 3 November 2009 at 15:49

After updating views to 6.27
Accordion also already updated

I've got problem using block views and field design.

Many fields are not exactly rendered. It seems that there are some missing closing HTML elements.

<div class="view-content"><!-- view itself -->
  <div class="item-list views-accordion views-accordion-newslinks-block_1">
    <h3 class="views-accordion-newslinks-block_1"><!-- first row (title) -->
      "Some data..."
    </h3>
    <div id="views-accordion-newslinks-block_1"><!-- 
      <div class="views-accordion-item accordion-item-0 accordion-item-odd accordion-item-first accordion-item-last">
        <div class="views-field-field-2nd-headline-value">
          <span class="field-content"/>
            [missing data]
          [missing closing "</span>"]
        </div>
          ...

Maybe there are more render bugs...

Comment #8

Manuel Garcia CreditAttribution: Manuel Garcia commented 3 November 2009 at 18:40

@CKIDOW

Can you please open up a new issue for this. Include as much info about the view options as needed to replicate your problem (screenshots help), if you are using custom tpl files etc.