include 1-time login link in email when account activated

Thank you!

Why not let them set the password at registration and never use a temporary password. Use the user status code, which is currently set to 0 when the user is not activated. I am totally not understanding the purpose of the temporary password!

See my suggestions in that same node.

I must not understand something, because I inserted the following single line after line 214

$user_status_loginurl = url("user/reset/$user->uid/$user->created/".user_pass_rehash($user->pass, $user->created, $user->login), NULL, NULL, TRUE);

and changed the line that previously read:

array($notify_site, $user->name, $notify_loginurl),

so that it now reads:

array($notify_site, $user->name, $user_status_loginurl),

and I was then able to use the %loginurl substitution in the "Activate status" body to display the one-time login link. Is it really that simple? Something must be wrong. Nothing is ever that simple.

To recap, the code now looks like this after line 212:

        case 1:
          if (variable_get('user_status_activated_enable', FALSE)) {
			$user_status_loginurl = url("user/reset/$user->uid/$user->created/".user_pass_rehash($user->pass, $user->created, $user->login), NULL, NULL, TRUE);
			return user_mail($user->mail,
                             str_replace(array('%site', '%user'),
                                          array($notify_site, $user->name),
                                          variable_get('user_status_activated_subject', user_status_activated_subject())),
                             str_replace(array('%site', '%user', '%loginurl'),
                                       array($notify_site, $user->name, $user_status_loginurl),
                                       variable_get('user_status_activated_body', user_status_activated_body())),
                             $headers);
		 }

Does this rise to the level of a patch? If so, does anybody want to give me a quick lesson on how to submit one? As you can tell, I've never submitted a patch before.

The more I look at what I've done so far, the less I like it. I need to add a variable to restore the ability to generate a link to the user's login screen (I had hijacked that variable for the one time login and that can't be right - that is just making one thing available at the expense of the other).

Also, I think the explanatory text that displays in the Administer->Settings->User_Status->Activate Status under the Body textarea needs to be expanded to reference the newly available variable.

I'll try to do this over the weekend, but I'm running out of time so if somebody else wants to do this, I won't complain.

And to add a little feature creep.... at this point, the routine does not hook into watchdog so the acts of sending the emails on Activation, Blocking and Deleting are not being recorded in the watchdog log. Something else I'll try to figure out.