Looking on how to use the extracting request handler for the attachments module, it seems that we need to allow a module to abort if there is a failure in constructing documents to index inside function function apachesolr_index_nodes()

CommentFileSizeAuthor
#7 allow-abort-611670-7-6x-2x.patch1.85 KBpwolanin
#6 apachesolr_allow_abort-611670-D5.patch2.35 KBclaudiu.cristea
#1 allow-abort-611670-1.patch1.17 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new allow-abort-611670-1.patch1.17 KB

Simplest approach - allow the callback to throw exceptions

JacobSingh’s picture

JacobSingh commented

Seems okay to me, switching the order of ops (setting $position and firing $callback) is probably fixing a potential bug too, right?

pwolanin’s picture

pwolanin commented
Title: Allow modules to abort the indexing » Allow modules to abort the building of documents for indexing
pwolanin’s picture

pwolanin commented

Right - setting those values after the callback runs means we retain the correct stopping point

pwolanin’s picture

pwolanin commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

committed to 6.x-1.x

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
StatusFileSize
new apachesolr_allow_abort-611670-D5.patch2.35 KB

Committed to DRUPAL-5--2. Attached the patch.

pwolanin’s picture

pwolanin commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new allow-abort-611670-7-6x-2x.patch1.85 KB

Here's a version for 6.x-2.x

robertdouglass’s picture

robertdouglass commented
Status: Needs review » Fixed

committed to 6.2.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.