function apachesolr_drupal_query($keys = '', $filters = '', $solrsort = '', $base_path = '') {
  list($module, $class) = variable_get('apachesolr_query_class', array('apachesolr', 'Solr_Base_Query'));
  include_once drupal_get_path('module', $module) .'/'. $class .'.php';

This makes it very hard to extend a class. Thanks again PHP for having absolutely no class dependency support (/me briefly and only mildly missing Java's package support).

Comments

jpmckinney’s picture

jpmckinney commented
Category: bug » task

Restricting, but not a bug, as we can always manually include the required parents/interfaces. I suppose we can do something like Views, where we have an array with the class name and any parents/interfaces it requires.

Scott Reynolds’s picture

Scott Reynolds commented

What about autoload module? Or setting up autoload (as you already required php5)?

In D7, registry helps is out right?

jpmckinney’s picture

jpmckinney commented

I agree: we should look into what D7 is doing, to see if that is an option for D6.

pwolanin’s picture

pwolanin commented
Status: Active » Closed (won't fix)