Attached is a patch which includes a new field into the module that allows petitioners to decide whether their signature gets displayed in result lists or if not, that their signature just counts anonymously.

CommentFileSizeAuthor
petition_node_newfield_canbedisplayed.patch13.6 KBjurgenhaas

Comments

seanr’s picture

seanr
he/him
commented

Looks OK, but the variable names and some of the help text are rather awkward. Let's change canbe_displayed to display and canbe_informed to optin. Descriptive text for buttons should be much more concise - for example: "Accept your signature to be displayed in lists" should be something like "Display your signature on the petition" or perhaps better "Make your signature public". If you can clean that stuff up and re-roll the patch, I'll test it and try to get it committed in the next few days.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

No problem, I'm happy to make the suggested changes, but there is one questions prior to that: the vraieble name canbe_informed has been there before and I used that as a pattern for canbe_displayed. When we now change that, do you want me to change the existing variables and (!) database field name for canbe_informed as well?