CVS edit link for cafuego

I wrote a module called content_profile_search that extends the content_profile (http://drupal.org/project/content_profile) module by allowing users with appropriate permissions to search for site users via text fields in their profile data.

It helps to quickly find users on sites that may have thousands and that may have profiles with a large number of fields.

I think the code is mature enough for a beta release.

CommentFileSizeAuthor
#5 content_profile_search.zip4.81 KBcafuego
#1 content_profile_search.zip4.69 KBcafuego

Comments

cafuego’s picture

cafuego commented
StatusFileSize
new content_profile_search.zip4.69 KB
cafuego’s picture

cafuego commented
Status: Postponed (maintainer needs more info) » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work 
  1.     'title' => 'Content Profile Search Settings',
    'description' => t('Change settings for the content_profile_search module'),

    The menu title, and description strings don't need to be passed to t().

  2. The code shows the profile fields without to first check if the users have the right permission.
  3. Why does the code show the form under admin/user/user rather than extending the users search form?
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Module review
cafuego’s picture

cafuego commented
Status: Needs work » Needs review
StatusFileSize
new content_profile_search.zip4.81 KB

1. I have removed the t() calls from hook_menu().

2. The module checks whether a user may view a field before searching it - provided the content_permissions module is available. The admin section lists all field names regardless, though, but may be accessed only by users with 'administer content profile search' permission. Only users with 'search content profile fields' fields can access the search form now.

3. I don't use the search module on any Drupals, so it was far easier to write a little stand-alone search module.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

It makes sense to put the form under admin/user/user if the form is thought to be used from administrator users. I find fine to leave it where it is under that condition.

As a little change, you should change the lines like

} else {

in

}
else {

Remove the information about the module version you added in the file .info; that information is added from the packaging script.

;
version = "6.x-0.1"
datestamp = 1255308013
cafuego’s picture

cafuego commented

Done - and thankyou :-)

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Module review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.