Since image field is part of the image module, the image module now depends on the file module. Simple patch to image.info

CommentFileSizeAuthor
#4 image-dep-file.patch531 bytessime
image.info.patch372 bytesjhedstrom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

sime’s picture

sime
any/any
Location Melbourne
CreditAttribution: sime commented
Status: Needs work » Needs review
FileSize
image-dep-file.patch531 bytes
carlos8f’s picture

carlos8f CreditAttribution: carlos8f commented

This issue is now a month old, how about some love?

1. commit the patch
2. ???
3. profit!

jim0203’s picture

jim0203 CreditAttribution: jim0203 commented
Status: Needs review » Reviewed & tested by the community

image.field.inc, line 107:

$form = file_field_instance_settings_form($field, $instance);

file.field.inc, line 109 onwards:

function file_field_instance_settings_form($field, $instance) {
  $settings = $instance['settings'];
  ...

So the dependancy is clearly there, and it's properly expressed in the patch. RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

I committed this earlier. Sorry!

carlos8f’s picture

carlos8f CreditAttribution: carlos8f commented
Status: Fixed » Reviewed & tested by the community

@webchick

Please check again--I'm not seeing dependencies[] = file in image.info.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Ok, sure of it this time. :P
http://drupal.org/cvs?commit=288474

Thanks. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.