The way we currently are handling the visibility settings for the comment form blocks is incompatible with block caching enabled.

We have to make the visibility check (wich includes a node_load()) in the operation 'visibility' instead of 'view'. To avoid multiple node_load() a static cache of that node object could be implemented.

Setting this to critical as we must fix this before a stable release.

Comments

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented

To avoid multiple node_load() a static cache of that node object could be implemented.

node_load() comes with it's own static caching mechanism, so the penalty for multiple calls to node_load with the same node id is negligable.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Assigned: dixon_ » Unassigned