If Job queue module would be optional (strongly recommended) why do I get this user warning when I upload a video:
user warning: Table 'grc_sandbox.job_queue' doesn't exist query: SELECT * FROM job_queue WHERE function = 'ffmpeg_converter_convert_filefield' in /mypath/modules/ffmpeg_converter/ffmpeg_converter.module on line 555.
After that I see this warning in the node:
The file TK20090806sm.wmv is waiting to be converted.
and it doesn't seem to be doing anything any more. Can it work without job_queue? Since this site is initially going to be used by few people with the right to upload videos, a job_queue is really not very useful for me.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | ffmpeg_converter_requirements3.patch | 2.62 KB | zoo33 |
| #4 | ffmpeg_converter_requirements2.patch | 2.53 KB | zoo33 |
| #3 | ffmpeg_converter_requirements.patch | 2.38 KB | zoo33 |
Comments
Comment #1
zoo33 commentedFileField and Job Queue are strongly recommended because FFmpeg Converter doesn't do much without them out of the box. You could use its API and configuration from other modules however but that's more or less it. I'd like this to change, maybe by using triggers/actions or Rules.
The fact that it was attempting to queue the file without Job Queue being active is a bug. There needs to be some kind of check for this in _nodeapi() I suppose.
Comment #2
ñull commentedWhat seems the simplest solution is adding "dependencies[] = job_queue" to ffmpeg_converter.info, because that is the matter of fact.
Comment #3
zoo33 commentedThe attached patch adds a couple of checks on the Status Reports admin page that tell you if you're missing any of the recommended modules. This is for 2.x, so the 1.x issue remains.
Also, not sure if rules actions are possible to create if Job queue is missing. So that should be checked too.
The patch depends on the patch in #893992: Use Ctools' export_ui to build the preset admin interface
Comment #4
zoo33 commentedHere's a new patch that fixes a stupid token error and rephrases some texts.
Comment #5
zoo33 commentedAdded FileField to the list of recommended modules.
Comment #6
zoo33 commentedI committed the patch above. So far so good. Now, we should also add suitable warning messages whenever:
– A file is sent to be queued without Job Queue being available.
– A rule is created/edited without the proper modules being available.