Please support i18n via the site-wide date format
Index: modules/ubercart/payment/uc_payment_pack/uc_payment_pack.admin.inc
===================================================================
--- modules/ubercart/payment/uc_payment_pack/uc_payment_pack.admin.inc (revision 15831)
+++ modules/ubercart/payment/uc_payment_pack/uc_payment_pack.admin.inc (working copy)
@@ -92,7 +92,11 @@
$form_state['values']['order_id'], mktime(12, 0, 0, $form_state['values']['clear_month'],
$form_state['values']['clear_day'], $form_state['values']['clear_year']));
- drupal_set_message(t('Check received, expected clear date of @date.', array('@date' => $form_state['values']['clear_month'] .'/'. $form_state['values']['clear_day'] .'/'. $form_state['values']['clear_year'])));
+ drupal_set_message(t('Check received, expected clear date of @date @date2.', array(
+ '@date' => $form_state['values']['clear_month'] .'/'. $form_state['values']['clear_day'] .'/'. $form_state['values']['clear_year'],
+ '@date2' => format_date(mktime(12, 0, 0, $form_state['values']['clear_month'],
+ $form_state['values']['clear_day'], $form_state['values']['clear_year']), 'medium'),
+ )));
$form_state['redirect'] = 'admin/store/orders/'. $form_state['values']['order_id'];
}
Comments
Comment #1
rszrama commentedI don't see how this change is a clear improvement. Wouldn't we just keep it as one date replacement and fix that one?
Comment #2
jonathan_hunt commentedSorry, the @date and @date2 was my testing. You probably want to use a single date subsitution based on 'uc_date_format_default ' per http://drupal.org/node/596728#comment-2124514
Comment #3
tr commentedBump up to 7.x-3.x - this code still has not been fixed in 7.x-3.x or in 6.x-2.x.
Comment #4
Island Usurper commentedOh look, we have a function for exactly this problem.
Comment #5
longwaveCommitted to both branches.