Files: 
CommentFileSizeAuthor
#9 drupal.theme-node-form.9.patch4.25 KBsun
PASSED: [[SimpleTest]]: [MySQL] 18,746 pass(es).
[ View ]
#7 drupal.theme-node-form.7.patch4.14 KBsun
PASSED: [[SimpleTest]]: [MySQL] 18,733 pass(es).
[ View ]
#5 drupal.theme-node-form.5.patch4.1 KBsun
Failed: Failed to apply patch.
[ View ]
#3 drupal.theme-node-form.3.patch2.46 KBsun
Failed: 13649 passes, 32 fails, 10 exceptions
[ View ]
drupal.theme-node-form.patch1.31 KBsun
Failed: 13650 passes, 32 fails, 165 exceptions
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch failed testing.

ksenzee’s picture

Besides the test failures, we also probably need CSS changes per http://drupal.org/node/296918#comment-974303.

sun’s picture

Status:Needs work» Needs review
StatusFileSize
new2.46 KB
Failed: 13649 passes, 32 fails, 10 exceptions
[ View ]

- Fixed tests.

- Fixed remnants in CSS.

Status:Needs review» Needs work

The last submitted patch failed testing.

sun’s picture

Status:Needs work» Needs review
StatusFileSize
new4.1 KB
Failed: Failed to apply patch.
[ View ]

This time for real.

Status:Needs review» Needs work

The last submitted patch failed testing.

sun’s picture

Component:node.module» markup
Assigned:Unassigned» sun
Status:Needs work» Needs review
StatusFileSize
new4.14 KB
PASSED: [[SimpleTest]]: [MySQL] 18,733 pass(es).
[ View ]

Just found this nice little patch again in my filesystem.

Jacine’s picture

Nice one! :D

Did you leave these two out by accident?

.node-form .container-inline .form-text {
  display: inline;
  width: auto;
}
.node-form .attachments fieldset {
  float: none;
  display: block;
}
sun’s picture

StatusFileSize
new4.25 KB
PASSED: [[SimpleTest]]: [MySQL] 18,746 pass(es).
[ View ]

Of course not! That was a test to see who'll catch it :P

Jacine’s picture

Status:Needs review» Reviewed & tested by the community

Haha! Ok, well it's all good now :D

Dries’s picture

Status:Reviewed & tested by the community» Fixed

Committed to CVS HEAD. Thanks.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Status:Closed (fixed)» Needs work

This was not documented in http://drupal.org/update/theme/6/7

sun’s picture

Issue tags:+Needs Documentation

.

jpmckinney’s picture

Issue tags:-DrupalWTF

No longer a WTF.

sun’s picture

Status:Needs work» Fixed

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Dave Reid’s picture

Status:Closed (fixed)» Fixed

FYI this patch left a watchdog message getting triggered on every node edit view because of a missing theme key 'node_form'. Please advise if the patch posted in #775012-13: Theme key watchdog errors on node pages is the correct solution.

Status:Fixed» Closed (fixed)
Issue tags:-Needs Documentation, -API clean-up

Automatically closed -- issue fixed for 2 weeks with no activity.