WTF @ http://api.drupal.org/api/function/theme_node_form/7 ?

CommentFileSizeAuthor
#9 drupal.theme-node-form.9.patch4.25 KBsun
#7 drupal.theme-node-form.7.patch4.14 KBsun
#5 drupal.theme-node-form.5.patch4.1 KBsun
#3 drupal.theme-node-form.3.patch2.46 KBsun
drupal.theme-node-form.patch1.31 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

ksenzee’s picture

ksenzee
she/her
Location Seattle area
CreditAttribution: ksenzee commented

Besides the test failures, we also probably need CSS changes per http://drupal.org/node/296918#comment-974303.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
drupal.theme-node-form.3.patch2.46 KB

- Fixed tests.

- Fixed remnants in CSS.

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
drupal.theme-node-form.5.patch4.1 KB

This time for real.

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Component: node.module » markup
Assigned: Unassigned » sun
Status: Needs work » Needs review
FileSize
drupal.theme-node-form.7.patch4.14 KB

Just found this nice little patch again in my filesystem.

Jacine’s picture

Jacine
she/her
Location New York
CreditAttribution: Jacine commented

Nice one! :D

Did you leave these two out by accident?

.node-form .container-inline .form-text {
  display: inline;
  width: auto;
}
.node-form .attachments fieldset {
  float: none;
  display: block;
}
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
FileSize
drupal.theme-node-form.9.patch4.25 KB

Of course not! That was a test to see who'll catch it :P

Jacine’s picture

Jacine
she/her
Location New York
CreditAttribution: Jacine commented
Status: Needs review » Reviewed & tested by the community

Haha! Ok, well it's all good now :D

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Closed (fixed) » Needs work

This was not documented in http://drupal.org/update/theme/6/7

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Issue tags: +Needs documentation

.

jpmckinney’s picture

jpmckinney CreditAttribution: jpmckinney commented
Issue tags: -DrupalWTF

No longer a WTF.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Fixed

Added docs. http://drupal.org/update/theme/6/7#theme-node-form

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Closed (fixed) » Fixed

FYI this patch left a watchdog message getting triggered on every node edit view because of a missing theme key 'node_form'. Please advise if the patch posted in #775012-13: Theme key watchdog errors on node pages is the correct solution.

Status: Fixed » Closed (fixed)
Issue tags: -Needs documentation, -API clean-up

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Needs documentation, +API clean-up

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.