comment_notify doesn't checks that the node teaser or other variables don't contain HTML tags even if it sends the mail using plain text.

Applying drupal_html_to_text() to the variables that can contain HTML, as suggested in other bug reports in the matter, fixes the issue.

CommentFileSizeAuthor
#4 593958_html_to_text_comment_notify.patch2.62 KBgreggles
comment_notify.module.patch2.07 KBDREAMER_ES
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

I marked #417396: Sends html tags in email as a duplicate of this. The patch no longer applies and I think ignored the need to render the content before stripping tags (what if people use a input format filter?).

Here's an alternate patch against the HEAD branch (i.e. 6.x-1.x-dev) which I think provides these features a bit more properly but which hasn't been tested thoroughly. Any testers?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Patch (to be ported) » Needs review

Oh, also, "to be ported" is for situations where the patch has been applied to 6.x-1.x-dev and needs to be ported (rewritten a bit) before it can be committed to 5.x-1.x-dev (both version numbers are examples). So, this is in "needs review" status.

rapsli’s picture

rapsli CreditAttribution: rapsli commented
Status: Needs review » Reviewed & tested by the community

works fine for me.
Tested it on the latest stable version 6.x-1.2

I mean, there's not that much that can go wrong with this patch ;)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Assigned: DREAMER_ES » greggles
Status: Reviewed & tested by the community » Needs review
FileSize
593958_html_to_text_comment_notify.patch2.62 KB

Actually that last patch doesn't commit any more and I seem to have failed to upload my own patch...

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs review » Patch (to be ported)

Now committed to 6.x http://drupal.org/cvs?commit=277482

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Version: 7.x-1.x-dev » 5.x-2.x-dev
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Assigned: greggles » Unassigned

To be ported, but not by me.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Patch (to be ported) » Closed (fixed)

This module is no longer actively developed for Drupal 5. If someone wishes to take over as the 5.x maintainer I would consider it, but these days everyone should really upgrade to Drupal 6.x.