I've been playing with the schema module, which uses the new database schema features of drupal6, and I'm reporting on the modules I use which don't contain any database description... I don't know whether to include this as code or documentation, since it's a bit of both.

The appended patch is my interpretation of the database schema.

CommentFileSizeAuthor
#1 588694_schema_description.patch2.12 KBdeviantintegral
m.patch1.41 KBespie

Comments

deviantintegral’s picture

deviantintegral commented
Version: 6.x-1.3 » 6.x-1.x-dev
Category: bug » feature
Status: Needs review » Needs work
StatusFileSize
new 588694_schema_description.patch2.12 KB

Good idea!

Here's an updated patch which:

  • Removes t() from the descriptions as DB descriptions aren't supposed to be translated.
  • Fixes some indentation issues.
  • Rewords the descriptions to be similar to core.

This patch still needs an update hook to add these descriptions to existing installations.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Reviewed & tested by the community

could you prepare a new release including this diff, please? That'd be great. Thanks.

deviantintegral’s picture

deviantintegral commented
Status: Reviewed & tested by the community » Fixed

I've committed the patch from #1 to HEAD and DRUPAL-6--1. I didn't do an update hook, but if anyone really wants that they can write it in a follow up patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 7c34d61 on master, 8.x-2.x, 8.x-2.x-admin-menu, 8.x-1.x-1836516 by deviantintegral: 
    #588694 by espie, deviantintegral, rickauer: Add database table...

  • Commit 7c34d61 on master, 8.x-2.x, 8.x-2.x-admin-menu, 8.x-1.x-1836516 by deviantintegral: 
    #588694 by espie, deviantintegral, rickauer: Add database table...