inconsistency between phptemplate_page and theme_page [#58671]

http://api.drupal.org/api/HEAD/function/phptemplate_page
http://api.drupal.org/api/HEAD/function/theme_page

theme_page() calls theme_closure(); directly
phptemplate_page() calls theme('closure')

one of both does it the false way...

Comment	File	Size	Author
#3	theme_closure_0.patch	532 bytes	flk
#3
#1	theme_closure.patch.txt	980 bytes	Tobias Maier

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Tobias Maier CreditAttribution: Tobias Maier commented 15 April 2006 at 07:34

Priority:	Normal	» Minor
Status:	Active	» Needs review

File	Size
theme_closure.patch.txt	980 bytes

since I cant see which one is the right one and it looks like that theme_closure() only contains logic
I replaced theme('closure') with theme_closure()

Comment #2

tenrapid CreditAttribution: tenrapid commented 15 April 2006 at 11:24

I think theme('closure') is right. It's a regular theme function and thus should be possible to override. The base function in theme.inc simply collects and concatenates the output of the closure hooks at the moment but one would like to process this further (putting it in a table, ...).

Comment #3

flk CreditAttribution: flk commented 5 September 2006 at 05:53

File	Size
theme_closure_0.patch	532 bytes

I would have to agree with tenrapid.
theme('closure') seems more right to me then theme_closure(). also it seems more in uniform with the other theme calls.
also wouldnt it be better to bring themes.inc inline with phptemplate.engine rather than the other way round?

btw whilst reading the api.d.o and found this: