Such as:
- test sent
- result received
- client add
- client approved
- test request / additional conditions on particular test

One area that can be cleaned then is:

if ($client['status'] == PIFR_SERVER_CLIENT_STATUS_TESTING) {
  pifr_server_client_confirmation_check($client, $result);
}

in pifr_server_test_result()

CommentFileSizeAuthor
#2 586262-event-hooks.patch2.63 KBboombatower

Comments

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower

The hooks almost align to:

define('PIFR_SERVER_LOG_CONFIRMATION_START', 1);
define('PIFR_SERVER_LOG_CONFIRMATION_PASS', 2);
define('PIFR_SERVER_LOG_CONFIRMATION_FAIL', 3);

define('PIFR_SERVER_LOG_TEST_REQUEST', 4);
define('PIFR_SERVER_LOG_TEST_REQUEST_MANAGER', 5);
define('PIFR_SERVER_LOG_TEST_REQUEST_IGNORE', 6);

define('PIFR_SERVER_LOG_CLIENT_REQUEST', 7);
define('PIFR_SERVER_LOG_CLIENT_RESET', 8);
define('PIFR_SERVER_LOG_CLIENT_RESULT', 9);
define('PIFR_SERVER_LOG_CLIENT_RETRIEVE', 10);

I am thinking the confirmation ones should provide access to the user object who owns the client.

boombatower’s picture

boombatower commented
Status: Active » Needs review
StatusFileSize
new 586262-event-hooks.patch2.63 KB
boombatower’s picture

boombatower commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.