In panels you are able to add a node to layout column. If you have 4 nodes with a title named "Example 1", "Example 2", "Example 3" and "Example 4" any you type in the autocomplete fields "Ex" the four node titles are shown in the dropdown. Moving the cursor to "Example 3" and pressing enter causes the item to get selected first and the [nid: 3] shown for a few seconds in the 'Enter the title or NID of a node' field, but then the auto-save comes in action and the selection is lost.

Selecting an node with this bug is nearly impossible... it was a challenge to figure out the nid in the 2 seconds after item selection and then write "[nid: 3]" in the autocomplete + saving than - only to add a node to a column.

I think I've found the form item that have this issues:

    $form['nid'] = array(
      '#prefix' => '<div class="no-float">',
      '#title' => t('Enter the title or NID of a node'),
      '#description' => t('To use a NID from the URL, you may use %0, %1, ..., %N to get URL arguments. Or use @0, @1, @2, ..., @N to use arguments passed into the panel.'),
      '#type' => 'textfield',
      '#maxlength' => 512,
      '#autocomplete_path' => 'ctools/autocomplete/node',
      '#weight' => -10,
      '#suffix' => '</div>',
    );
CommentFileSizeAuthor
#10 fix-autocomplete-581670.patch612 bytesmariacha1
#10 bad-autosubmit-keypress.png49.04 KBmariacha1
#10 good-autosubmit-keypress.png49.83 KBmariacha1
#4 fix-autocomplete.patch1.31 KBmerlinofchaos
#2 fix-autocomplete.patch1.1 KBmerlinofchaos

Comments

hass’s picture

hass commented
Title: Autocomplete loose selected item on auto-save » Autocomplete loose selected item after selection

Not sure if this is "auto-save"

merlinofchaos’s picture

merlinofchaos commented
Status: Active » Needs review
StatusFileSize
new fix-autocomplete.patch1.1 KB

Does this fix it for you?

hass’s picture

hass commented
Status: Needs review » Needs work

Yes, it prevents the lost item selection, but shows the status-active.gif next to the submit button without any action (DIV with class "ctools-ajaxing"). Pressing the submit button adds an additional status-active.gif until the modal window closes.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs work » Needs review
StatusFileSize
new fix-autocomplete.patch1.31 KB

Hm. Try this one instead.

hass’s picture

hass commented
Status: Needs review » Reviewed & tested by the community

Tested, and works well. THX

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Checked in!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nagiek’s picture

nagiek commented
Version: 6.x-1.0 » 7.x-1.x-dev
Status: Closed (fixed) » Active

Hi, sorry to open this up again, but it seems it was lost somewhere along the way.

Same fix applies, but needs to be placed in modalEventHandler.

    modalEventHandler = function( event ) {
      
      ...

      // Stop autocomplete from submitting.
      if (Drupal.autocompleteSubmit && !Drupal.autocompleteSubmit()) {
        event.preventDefault();
      }

Will contribute a patch.

fourmi4x’s picture

fourmi4x commented

Hi, thanks a lot nagiek, your fix works great on drupal 6 too.

mariacha1’s picture

mariacha1 commented
Status: Active » Needs review
StatusFileSize
new good-autosubmit-keypress.png49.83 KB
new bad-autosubmit-keypress.png49.04 KB
new fix-autocomplete-581670.patch612 bytes

I'm attempting a patch to take care of this for 7.x-1.x-dev (at e81da7a).

Here's a couple images trying to explain the situation for refreshing people's memory:

Currently typing a few letters into the autocomplete, hitting the down arrow button to select your desired node, then hitting "Enter" ALSO submits the form with the junk few letters you typed.
Bad error submit

So the patch requires you to hit "Enter" again to submit the form itself. This is the default behavior of Drupal's autosubmit:
Good error submit

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +Accessibility

This problem is still present in CTools 1.4 and this patch still fixes it! (It applies with some fuzz - offset 9 lines)

This is also an accessibility problem: it makes it difficult to use the autocomplete via the keyboard (although, it's still possible by using the TAB key rather than ENTER - but how is anyone to know that?).

We're going to start using this patch in Panopoly soon because of the accessibility impact.

  • japerry committed ae66d65 on 7.x-1.x authored by mariacha1 
    Issue #581670 by mariacha1, hass: Autocomplete loses selected item after...
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Long standing annoyance that is reproducible. Patch works for me as well, soo... Fixed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.