With nothing else being different, I have not altered the core ubercart CA predicates.

The order status updates on a renewal order fire differently and worng, thus granting a role promotion, the role promotion CA is such that it is fired when the order status goes from Payment Received to completed, this happens in the original order but not the renewal order.

I am running latest bzr Ubercart, and cvs of latest uc_recurring.

CommentFileSizeAuthor
#2 Renewal with normal status71.78 KBthill_
#1 uc_recurring-580226.patch1.83 KBunivate
Recurring Created Order95.99 KBthill_
Origianl Order71.78 KBthill_

Comments

univate’s picture

univate commented
Status: Active » Needs review
StatusFileSize
new uc_recurring-580226.patch1.83 KB

This patch should generate the following order_status events for a renewal that completes and is payed for in full:

processing -> pending -> payment_received -> completed

but it also should leave a renewal in the pending status if no payment is received but the order is still renewed (e.g. when you are not using any payment modules onsite, instead payments are handled manually some other way)

thill_’s picture

thill_ commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Renewal with normal status71.78 KB

Awesome it works like expected, giving the new order the status updates like it should, it triggered the role renewal.

vitis’s picture

vitis commented

thank you, univate

univate’s picture

univate commented
Status: Reviewed & tested by the community » Fixed

I have committed this, although I have added a TODO in the code so that we can address the issue of having CA handle the order status being changed to completed instead of being done manually in the code.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.