If you disable the Comment subject field in Admin>Content Management>Content Types>ContentName>Comment Settings , then the module has not effect.

It should still work in my opinion.

CommentFileSizeAuthor
#5 2009-11-18_support_comment_update_6002_preserving_backward_compatibility.patch959 bytesarhak
#3 2009-09-13_support_comment_update_6002_preserving_backward_compatibility.patch1.01 KBarhak
#2 2009-09-13_support_comment_update_6002_preserving_backward_compatibility.patch881 bytesarhak
#1 2009-09-13_support_comment_update_6002.patch664 bytesarhak
#1 2009-09-13_support_comment_update_6002.patch664 bytesarhak

Comments

arhak’s picture

arhak commented
Title: Not working with Comment subject field disabled » support comment_update_6002 (Not working with Comment subject field disabled)
Category: feature » bug
Status: Active » Needs review
StatusFileSize
new 2009-09-13_support_comment_update_6002.patch664 bytes
new 2009-09-13_support_comment_update_6002.patch664 bytes

since comment_update_6002 having subject disabled makes the module useless due to an out of date variable name

arhak’s picture

arhak commented
StatusFileSize
new 2009-09-13_support_comment_update_6002_preserving_backward_compatibility.patch881 bytes

a new patch which is compatible with comment_update_6002 and also preserves backward compatibility for older schema versions of comment module

arhak’s picture

arhak commented
StatusFileSize
new 2009-09-13_support_comment_update_6002_preserving_backward_compatibility.patch1.01 KB

@#2 sorry, I missed a line

arhak’s picture

arhak commented

this patch still needs review

arhak’s picture

arhak commented
Title: support comment_update_6002 (Not working with Comment subject field disabled) » disabled subjects not working after comment_update_6002
StatusFileSize
new 2009-11-18_support_comment_update_6002_preserving_backward_compatibility.patch959 bytes

It seems that there is no one using 6.x-1.4 with subjects disabled,
or they might thought it wasn't intended to work with this module

nevertheless, I'm attaching now the right patch
since, patch #3 was made without rolling back patch #1 and therefore doesn't apply against any version

PS: 6.x-1.5 should be released soon with this fix committed

arhak’s picture

arhak commented
Status: Needs review » Fixed

released 6.x-1.5 with this fixed

arhak’s picture

arhak commented
Status: Fixed » Closed (fixed)

almost two weeks now, I'm closing it to clean up the issue queue