project_issue_node_form_validate() shouldn't try to alter $form_values

project_issue_node_form_validate() is currently attempting to modify $form_values, which is apparently a big no-no from inside a FAPI validate() hook. according to gatsby on the #drupal IRC:

|gatsby|: dww: You are not actually supposed to modify anything in _validate regardless of that patch - You can do so only with #refs. It's like a maxim

here's the problem code:

function project_issue_node_form_validate($form_id, $form) {
  global $form_values;
  ...
    if ($form_values['pid'] && $project = node_load($form_values['pid'])) {
      $node->title = $form_values['title'];
      if ($releases = project_release_load($project)) {
        if (!$form_values['rid'] || !$releases[$form_values['rid']]) {
          $form_values['rid'] = $project->version;
        }
        empty($form_values['rid']) and form_set_error('rid', t('You have to specify a valid version.'));
      }
      if ($form_values['component'] && !in_array($form_values['component'], $project->components)) {
        $form_values['component'] = 0;
      }
  ...
      $file = file_check_upload('file_issue');
      $form_values['file'] = file_save_upload($file);
  ...
}

as soon as #56921 is committed, project will break unless we fix this. sadly, i don't have time to roll a patch right now. i hope someone else can take care of this soon.

thanks,
-derek