The Logging and Errors page has a setting to decide what kinds of error messages will be displayed on the screen. The setting is named "Display PHP messages", which is kind of misleading, and is also missing a description for its options. I suggest we:

- change "Display PHP messages" to "Error messages to display"
- add a description to the setting

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lut4rp’s picture

Status: Active » Needs review
FileSize
1.12 KB
joshmiller’s picture

Issue tags: +Needs usability testing
FileSize
17.46 KB

Attached is a screenshot.

I think the title might better read "Display Error Messages." I really like the new description.

The patch code is RTBC. Applies with a little fuzz, but nothing bad.

yoroy’s picture

Status: Needs review » Needs work
Issue tags: -Needs usability testing +Usability, +ui-text

Please remove the first sentence of the description, it only repeats the label thus not offering any new information.
leaves:
__
Sites running in a production environment are recommended not to display any errors, but they may be helpful in a development or testing environment.
__

"they" seems to refer to the sites, not the errors?

If this lets you choose which ones to show, is it necessary to suggest when they'd be helpful at all?

Why not just:
__
Sites running in a production environment are recommended not to display any errors.
__

Not sure if that's the most concise way of putting it but that's all we need to tell I think.

reglogge’s picture

New patch with suggestions from #3
Screenshot attached

On another note: The default value in PHP error reporting is set to ERROR_REPORTING_DISPLAY_ALL. I think it would be safer to set the default to ERROR_REPORTING_HIDE, so that inexperienced site-owners have to actually turn error reporting on if they want the world to see those pesky error messages.

Opinions?

reglogge’s picture

Status: Needs work » Needs review

enabling bot

webkenny’s picture

Maybe I'm just being picky but I feel like the sentence, "Sites running in a production environment are recommended not to display any errors" is a little difficult in it's read.

What about something a little more friendly like "It is recommended that sites running on production environments not display any errors."

Just seems a little easier off the tongue, IMO. (Also cleaned up the grammar a touch)

Also, it's hard to know if the plural should be used or the singular. (e.g. "that a site running on a production environment"). But I'll leave that open for discussion.

yoroy’s picture

Status: Needs review » Needs work

I agree that current sentence is cumbersome and I like the suggestion too, with one question (from a non-native speaker):

suggested in #6:
It is recommended that sites running on production environments not display any errors.

What I was missing from that sentence is *do* not display:
It is recommended that sites running on production environments do not display any errors.
I know the first is correct, too, but it reads a bit more abstract to me.

webkenny’s picture

Agree. The do does make it clearer. Both are correct but the 2nd makes it easier to read (and likely translate).

webkenny’s picture

Status: Needs work » Needs review
FileSize
1.08 KB

Giving that a whirl. Patch attached.

Dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Xano’s picture

Version: 8.x-dev » 7.x-dev

The Logging and Errors page has a setting to decide what kinds of error messages will be displayed on the screen. The setting is named "Display PHP messages", which is kind of misleading, and is also missing a description for its options.

1) It is not misleading, because this setting actually only applies to PHP's messages (notices, errors, warnings and such)
2) Form elements do not necessarily need a description. Also, we decided not to tell site admins how to set up their website from within Drupal, especially when it's about development site versus live site options.

I suggest we revert the entire patch.

//Edit: Yes, reverting the patch requires a string change (and one string removal), but the current string just doesn't make clear what the setting does. One would have to check the source code to find it out.

Bojhan’s picture

Version: 7.x-dev » 8.x-dev
Status: Closed (fixed) » Active

Core freez, non critical

Xano’s picture

This is a bug, and although it's not critical, bugs will still be fixed until Drupal 9 comes out.

Bojhan’s picture

Title: Fix the title and description for "Error message display" in Logging and Errors » Revert: Fix the title and description for "Error message display" in Logging and Errors
Assigned: lut4rp » Unassigned
Xano’s picture

Assigned: Unassigned » Xano
FileSize
1.15 KB

BAM!

Xano’s picture

Status: Active » Needs review
Xano’s picture

Can we give this issue a boost before RC1 comes out and we're in string freeze? Note that this is about a (minor) bug, because what the UI text says about the configuration option is a bit misleading.

Xano’s picture

Assigned: Xano » Unassigned

  • Dries committed 1488a39 on 8.3.x
    - Patch #569276 by lut4rp, reglogge, webkenny: Fixed the title and...

  • Dries committed 1488a39 on 8.3.x
    - Patch #569276 by lut4rp, reglogge, webkenny: Fixed the title and...

  • Dries committed 1488a39 on 8.4.x
    - Patch #569276 by lut4rp, reglogge, webkenny: Fixed the title and...

  • Dries committed 1488a39 on 8.4.x
    - Patch #569276 by lut4rp, reglogge, webkenny: Fixed the title and...

  • Dries committed 1488a39 on 9.1.x
    - Patch #569276 by lut4rp, reglogge, webkenny: Fixed the title and...