First, thanks for a great module.

I have a questions about the use if "file_directory_path()" as the "originalFileDirecotry" and it's use in DrupalWebTestCase->drupalGetTestFile.

This points to the sites 'files/simpletest' directory. Since the copying of the files could fail in the module install (like mine did), I propose that we add a check to see if the file exists. If it doesn't, check the drupal_get_path('module', 'simpletest') . '/files' location. Otherwise you get alot of failure in many different simpletest module scripts, including imagefield and fieldfield.

I'm attaching a patch for this.

CommentFileSizeAuthor
#1 simpletest-568526.patch961 bytesindytechcook

Comments

indytechcook’s picture

indytechcook commented
StatusFileSize
new simpletest-568526.patch961 bytes

Attaching patch.

indytechcook’s picture

indytechcook commented
Status: Active » Needs review

setting to needs review.

boombatower’s picture

boombatower commented

Perhaps we should just make a failure message during install?

boombatower’s picture

boombatower commented
Status: Needs review » Postponed (maintainer needs more info)

Also, how does it fail. If it has write access and all it should work?

indytechcook’s picture

indytechcook commented

It failed during the install profile. I'm not exactly sure how it failed. I'll step through with the debugger.

I had first thought about giving the ability to specify a file location which could be useful for other modules.

Also, how does it fail. If it has write access and all it should work?

That is a very good question. I didn't find any good reason why it failed, my only thought is that it had something to do with the install profile.

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Postponed (maintainer needs more info) » Closed (fixed)

Please re-open if you have more details.