Hi,

First of all, thank you for this very nice and clean-looking theme.

I see that in theme configuration settings, there is no option for a site logo. Wouldn't it be nice if you allow us to use a logo?

Sinan

Comments

kong’s picture

kong CreditAttribution: kong commented

Hi Sinan,

Thanks for the feedback :)

I've added logo support in CVS. Please wait until the 6.x-1.x-dev package is regenerated and give it a try. If everything's OK then I'll create an official release.

Sinan Erdem’s picture

Sinan Erdem CreditAttribution: Sinan Erdem commented

Thank you for the quick reply and the good news ;)

Sinan

Sinan Erdem’s picture

Sinan Erdem CreditAttribution: Sinan Erdem commented

Just trying the new logo feature on your latest dev snapshot. It works nice. But;

1. The search button (magnifier image) is now placed under the search text box, and the actual text area starts some 75 px right from its desired position. Also there is a light-blue border around the search box on IE6 and the nav menu drops 10 or more pixels down. I think this CSS tag breaks the search box:

#header.with-logo p {
margin:0 0 0 75px;
}

If I set the margin to 0, it works...

2. The CSS automatically resizes the logo to 60px. If I erase the height property of the #logo, then te nav menu drops a little down. I may also change the relative position of the nav menu from 46px to a lower value. I think carrying the nav menu to "content" area instead of "header" and giving header a fixed height might solve the problem. But of course, it is your decision.

You can see the latest result: http://www.cmaenerji.com.tr

Thanks,

Sinan

kong’s picture

kong CreditAttribution: kong commented

Whoops, I forgot to enable the search box when testing the theme.

Thanks for your suggestions, I will take a look and try to fix it.

kong’s picture

kong CreditAttribution: kong commented

OK, here are the list of changes:

1. The search button positioning is fixed
2. The logo height in CSS is removed, you can use logo of any size. However, it's still limited by the height of the header div background image.
3. The navigation tabs is removed from the header. You shouldn't have to adjust its position anymore.

Let's try the dev snapshot and see if it works.

Sinan Erdem’s picture

Sinan Erdem CreditAttribution: Sinan Erdem commented
Status: Active » Closed (fixed)

Fantastic job!

I tested the latest dev snapshot on FF and IE6. Regarding the logo, I didn't find any bug. By the way, the Drupal logo you used looks great on this theme.

This theme will be popular in no time :)

Cheers,

Sinan