The Simple Test scripts fails for 6.x-alpha3. Attached is a patch to the test script to fix it.

All of theme were in the testLinkContents function of test/admin_menu.text

One line was searching for a complete div tag.

  $this->assertRaw('<div id="admin-menu">', t('Administration menu is displayed.'));

It didn't take into account any css classes or other div tags.

The other 4 failures were improperly formatted URL's. I just used the url function.

Cheers,
Neil

CommentFileSizeAuthor
#4 admin_menu-567618.patch5.18 KBneclimdul
#1 admin_menu-567618.patch5.02 KBindytechcook
admin_menu.test.patch1.7 KBindytechcook

Comments

indytechcook’s picture

indytechcook commented
StatusFileSize
new admin_menu-567618.patch5.02 KB

updated patch to move all '>' from checks for admin-menu div.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Tests pass on the latest DRUPAL-6--3 code. Marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

neclimdul’s picture

neclimdul
He/Him
commented
Version: 6.x-3.0-alpha3 » 6.x-1.x-dev
Assigned: indytechcook » neclimdul
Status: Closed (fixed) » Needs review
StatusFileSize
new admin_menu-567618.patch5.18 KB

Backported to 1.x since its relevant. Works for me.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Thanks for reporting, reviewing, and testing! Committed to 1.x.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.