cannot install Drupal when Drupal.org is 503 (at Drupalcon!)

Your patch was bases on an old version of D7.
This one should do the trick

Looks like you didn't manage to attract the right folks to this issue due to a wrong component.

Did a reroll don't know if it's still relevant.

hmm bot glitch?

In general coding and documentation standards need a lot of work. Comments need to be wrapped at 80 characters, functions have starting curly brace on the same line as function name, etc. We also probably need a unit test for this function to ensure it works properly, since I'm guessing that's why we're getting the test failure.

+++ includes/common.inc	23 Mar 2010 12:33:54 -0000
@@ -6124,6 +6124,46 @@
+ * @param array $array1
+ * @param array $array2
+ * @return array
+ * @author Daniel <daniel (at) danielsmedegaardbuus (dot) dk>
+ * @author Gabriel Sobrinho <gabriel (dot) sobrinho (at) gmail (dot) com>

Does not follow standards for @param or @return. We don't also put credits in functions like this.

Powered by Dreditor.

True, I don't know how the function works, just wanted to push this but I admit I didn't look at the awful comment style!

#4 and #6 seem to be completely unrelated to this bug, unless someone can explain how they're connected.

Note, it should be possible to reproduce this via creative use of the 'update_fetch_url' variable.

Here's a test ...

I added the following bit of code which prevents XML parsing if drupal_http_request had any sort of error, like not being able to successfully fetch the xml data.

--- modules/update/update.fetch.inc
+++ modules/update/update.fetch.inc
@@ -144,7 +144,7 @@ function _update_process_fetch_task($project) {
 
   if (empty($fail[$fetch_url_base]) || $fail[$fetch_url_base] < $max_fetch_attempts) {
     $xml = drupal_http_request($url);
-    if (isset($xml->data)) {
+    if (!isset($xml->error) && isset($xml->data)) {
       $data = $xml->data;
     }
   }

I didn't touch any cache clearing code (as in #2, for example), as that seems to be working okay for the moment.

Changed the relevant test slightly to also look for the text

'Failed to get available update data for one project.'

Tests are in #13 and the patch+tests are in #15.

The actual change to runtime code is small:

     $xml = drupal_http_request($url);
-    if (isset($xml->data)) {
+    if (!isset($xml->error) && isset($xml->data)) {

The remainder of the patch just adds a test case as evidenced in #13.

#16 tested against 7.x and is working.

Reviewed this patch and decided to commit it to 7.x and 8.x. Good catch! :)