Defined order not respected when Style different than Draggable Table

Mmm, there's no way to make settings for other displays. So should they always use arguments, or not?
I'll have to think about this a little more. But in the meanwhile the attached patch should make it:
The argument will be used in queries for all displays whenever an argument is present (except it is not checked at the Draggable table settings).

THIS IS NOT THE FINAL SOLUTION.
Before you use this patch you'll have to update to the latest dev version. (I recently committed some form-api changes; not relevant for this issue).

Everytime a view gets built the following function gets called:

views/draggableviews.views.inc:

function draggableviews_views_query_alter(&$view, &$query) {
  for ($i = 0; $i < 2; $i++) {
    if (isset($query->table_queue['draggableviews_structure_'. $view->base_table . $i])) {
      $query->table_queue['draggableviews_structure_'. $view->base_table . $i]['join']->extra[] = array(
        'field' => 'view_name',
        'operator' => '=',
        'value' => $view->name,
      );
      $args = NULL;
      if (!isset($view->style_plugin->options['draggableviews_arguments']['use_args']) || !empty($view->style_plugin->options['draggableviews_arguments']['use_args'])) {
        if (!empty($view->args)) {
          $args = implode('/', $view->args);
        }
      }
      $query->table_queue['draggableviews_structure_'. $view->base_table . $i]['join']->extra[] = array(
        'field' => 'args',
        'operator' => '=',
        'value' =>  $args, 
      );
    }
  }
}

The line with the options['draggableviews_arguments'] is relevant.
Every time this functions gets called I've to decide whether the "args" should be used to build the query or not. The information I have at this point:

• Which view is beeing built
• Which display is beeing built

If the display to build USES "Draggable Table" style plugin it's easy:
I just read the configuration settings of the style-plugin of this display.

But if the display to build DOES NOT USE "Draggable Table" style plugin we have a problem:
There might be another display that uses "Draggable Table" style plugin in this view. But we don't know. Is there such a display? Does the style-plugin of this display is configured to use arguments?

Summerized:
On the one hand all views displays are independent and don't deal with each other.
On the other hand DraggableViews Native handler offers "DraggableViews: Order" (a field) that is the same for all displays.

I cannot assume that the user wants all displays to use arguments because only one of the displays does.

Does this helps understanding the problem? :)

Many thanks for digging so deep to reveal the core of the matter. I just nodded my head in agreement while I was reading your answer :)

If any display uses arguments (and defines the "DraggableViews: Order" field; Native handler assumed) all unconfigured displays (non-"Draggable Table"-style-plugins) will use arguments in their queries too.

Right?

Ok,
the attached patch should do it.

After committing I'll mention this in documentation.

Greetings,
sevi

I think that a software developer sometimes has to be bold. He has to take a chance even if it could mean a loss (serious self-reviewing assumed).
As far as I can remember is this roughly what Dries Buytaert told us last Wednesday while opening the Drupal Conference in Paris.

So I scrape all my boldness together and commit this patch now :)

Thanks for reviewing,
greetings,
sevi

this is D7, but when i try to apply this patch on 7.x-2.x-dev. i got this errors.

patching file draggableviews.views.inc
Hunk #1 FAILED at 112.
Hunk #2 FAILED at 154.
2 out of 2 hunks FAILED -- saving rejects to file draggableviews.views.inc.rej

I'm really puzzled, since i can't even find draggableviews_views_query_alter function in views/draggableviews.views.inc file, how exactly this patch is generated ? Please advice. thank you

It seems to me this patch is against 1.x branch, and it's been removed from 2.x branch !!