A lot of notices are in those theme form_element calls. Instead of checking for every instance of the presence of the multitude of attributes, I'm passing $element and let form_element check for presence, which was already present anyways.

CommentFileSizeAuthor
#17 remove_notices_2.patch9.91 KBchx
#16 remove_notices_1.patch9.38 KBchx
#15 remove_notices_0.patch10.47 KBchx
#13 remove_notices.patch14.25 KBchx
#9 remove_notces_3.patch10.78 KBchx
#8 remove_notces_2.patch11.41 KBchx
#7 remove_notces_1.patch12.2 KBchx
#6 remove_notces_0.patch12.2 KBchx
#1 remove_notces.patch12.81 KBchx

Comments

chx’s picture

chx commented
StatusFileSize
new remove_notces.patch12.81 KB

Last I checked we have a bug which needs a followup to attach.

killes@www.drop.org’s picture

killes@www.drop.org commented

can somebody please test this?

puneetc’s picture

puneetc commented

I just downloaded this patch and applied it but am still getting the following errors:

# warning: Missing argument 2 for filter_form_validate() in /drupal3/modules/filter.module on line 833.
# warning: implode() [function.implode]: Bad arguments. in /drupal3/includes/form.inc on line 296.
# warning: Missing argument 2 for filter_form_validate() in /drupal3/modules/filter.module on line 833.
# warning: implode() [function.implode]: Bad arguments. in /drupal3/includes/form.inc on line 296.

Zen’s picture

Zen commented
Status: Needs review » Needs work

Patch needs a re-roll.

-K

puneetc’s picture

puneetc commented

Any ETA?

chx’s picture

chx commented
StatusFileSize
new remove_notces_0.patch12.2 KB

Can't believe I needed to reroll...

chx’s picture

chx commented
StatusFileSize
new remove_notces_1.patch12.2 KB

A simplified version (this patch is the direct descendant of the #prefix / #suffix theme patch and things that were necessary there aren't here).

chx’s picture

chx commented
StatusFileSize
new remove_notces_2.patch11.41 KB

Bad file attached.

chx’s picture

chx commented
StatusFileSize
new remove_notces_3.patch10.78 KB

Some testing...

Tobias Maier’s picture

Tobias Maier commented
Status: Needs work » Needs review

status...

killes@www.drop.org’s picture

killes@www.drop.org commented

Too large to include it as this stage of development. Should probably be committed on HEAD after 4.7 has been branched off.

chx’s picture

chx commented
Status: Needs review » Postponed
chx’s picture

chx commented
StatusFileSize
new remove_notices.patch14.25 KB
Zen’s picture

Zen commented
Status: Postponed » Needs work

This one needs a re-roll.

-K

chx’s picture

chx commented
Status: Needs work » Postponed
StatusFileSize
new remove_notices_0.patch10.47 KB
chx’s picture

chx commented
StatusFileSize
new remove_notices_1.patch9.38 KB
chx’s picture

chx commented
Status: Postponed » Reviewed & tested by the community
StatusFileSize
new remove_notices_2.patch9.91 KB
drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

Form.inc is quite sloppy with the '.' should be next to quotes code style rule. I corrected this in the added lines.

I also updated for a conflict caused by #61304 being comitted.

Comitted to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)