Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
A lot of notices are in those theme form_element calls. Instead of checking for every instance of the presence of the multitude of attributes, I'm passing $element and let form_element check for presence, which was already present anyways.
Comment | File | Size | Author |
---|---|---|---|
#17 | remove_notices_2.patch | 9.91 KB | chx |
#16 | remove_notices_1.patch | 9.38 KB | chx |
#15 | remove_notices_0.patch | 10.47 KB | chx |
#13 | remove_notices.patch | 14.25 KB | chx |
#9 | remove_notces_3.patch | 10.78 KB | chx |
Comments
Comment #1
chx CreditAttribution: chx commentedLast I checked we have a bug which needs a followup to attach.
Comment #2
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedcan somebody please test this?
Comment #3
puneetc CreditAttribution: puneetc commentedI just downloaded this patch and applied it but am still getting the following errors:
# warning: Missing argument 2 for filter_form_validate() in /drupal3/modules/filter.module on line 833.
# warning: implode() [function.implode]: Bad arguments. in /drupal3/includes/form.inc on line 296.
# warning: Missing argument 2 for filter_form_validate() in /drupal3/modules/filter.module on line 833.
# warning: implode() [function.implode]: Bad arguments. in /drupal3/includes/form.inc on line 296.
Comment #4
Zen CreditAttribution: Zen commentedPatch needs a re-roll.
-K
Comment #5
puneetc CreditAttribution: puneetc commentedAny ETA?
Comment #6
chx CreditAttribution: chx commentedCan't believe I needed to reroll...
Comment #7
chx CreditAttribution: chx commentedA simplified version (this patch is the direct descendant of the #prefix / #suffix theme patch and things that were necessary there aren't here).
Comment #8
chx CreditAttribution: chx commentedBad file attached.
Comment #9
chx CreditAttribution: chx commentedSome testing...
Comment #10
Tobias Maier CreditAttribution: Tobias Maier commentedstatus...
Comment #11
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedToo large to include it as this stage of development. Should probably be committed on HEAD after 4.7 has been branched off.
Comment #12
chx CreditAttribution: chx commentedComment #13
chx CreditAttribution: chx commentedComment #14
Zen CreditAttribution: Zen commentedThis one needs a re-roll.
-K
Comment #15
chx CreditAttribution: chx commentedComment #16
chx CreditAttribution: chx commentedComment #17
chx CreditAttribution: chx commentedComment #18
drummForm.inc is quite sloppy with the '.' should be next to quotes code style rule. I corrected this in the added lines.
I also updated for a conflict caused by #61304 being comitted.
Comitted to HEAD.
Comment #19
(not verified) CreditAttribution: commented