This is a patch that I've been using on my local that get's rid of feedapi_eparser_feedapi_parse(). There are 2 main advantages:
1. feedapi_eparser_type_plugin_method_call() lets you call any plugin method with all the error checking and init() calling of feedapi_eparser_feedapi_parse()
2. The caching logic is moved into ->parse() so it can be overridden by plugins
To do this I also made _feedapi_eparser_load_type_plugin() take a plugin name instead of a feed which I think makes more sense as it differentiates it from feedapi_eparser_load_type_plugin
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 562766.patch | 6.19 KB | neclimdul |
| #1 | 562766.patch | 0 bytes | neclimdul |
| eparser3.patch | 7.3 KB | andrewlevine |
Comments
Comment #1
neclimdulI wasn't keen on this but the more I messed with things I think there's a need for at least most of this patch. How does the attached patch fit with the idea?
It does a couple things.
Moves the call to download into parse(I think it might have been there anyways at one point).
Moves the cache logic into ->parse() like your patch but wrapping ->download as well.
It doesn't add a method for calling these methods. However since you can load it and call it directly now things are pretty simple. See the call to parse in the feedapi hook.
Comment #2
neclimdulreal patch...
Comment #3
andrewlevine commentedI didn't have a chance to actually test this patch but the refactoring is better than both what is in feedapi_eparser now and my patch. It makes more sense to do the initialization on plugin load than on method call. If you've confirmed this working on your local, I'd say commit it and then I will test it.
Comment #4
neclimdulsounds good to me. committed.
Comment #5
andrewlevine commentedtested and seems to work fine. thanks