The user settings to enable/disable email notification at the account level used to be at messages/notify, but were later moved to the user account edit page. The default notification email still contains a link to messages/notify, that should instead point to user/{userid}/edit. The attached patch hopefully fixes this. I had to add a new token, !author_uid, to create the correct url.

CommentFileSizeAuthor
#7 real_fix_this_time.patch2.36 KBberdir
pm_email_notify.module.patch1.92 KBsja1

Comments

sja1’s picture

sja1 commented
Status: Active » Needs review

changing status

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Did not actually test it, but the changes are obvious and the patch still applies.

litwol’s picture

litwol commented
Status: Reviewed & tested by the community » Fixed
litwol’s picture

litwol commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Fixed » Patch (to be ported)
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Patch (to be ported) » Reviewed & tested by the community

Patch applies to 7.x-1.x too :)

litwol’s picture

litwol commented
Status: Reviewed & tested by the community » Fixed

With offsets.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Needs review
StatusFileSize
new real_fix_this_time.patch2.36 KB

Well, that happens when you RTBC a patch without testing..

The fix is actually wrong, it does insert the UID of the *author* into the edit link, however, the recipient does not have access to that, obvously...

litwol’s picture

litwol commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Patch (to be ported) » Reviewed & tested by the community

Patch applies and works. With fuzz, but I assume that's because of a changed comment or something like that.

litwol’s picture

litwol commented
Status: Reviewed & tested by the community » Needs work

Sorry please re-roll

 patch -p0 < real_fix_this_time_0.patch
patching file pm_email_notify/pm_email_notify.module
Reversed (or previously applied) patch detected!  Assume -R? [n] ^[
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

This has already been commited as part of http://drupal.org/cvs?commit=264130.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.