Let's patch test that it should not try to add already existing mapping entries. Or let's override the mapping first and delete everything.

CommentFileSizeAuthor
#2 558028_not_add_default_mapping.patch5.4 KBAron Novak
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Aron Novak’s picture

Aron Novak
Primary language Hungarian
Location Hungary, Budapest
CreditAttribution: Aron Novak commented
Status: Active » Needs review

Only commit after #557512: Add default mapping for FEMP 2.x

Aron Novak’s picture

Aron Novak
Primary language Hungarian
Location Hungary, Budapest
CreditAttribution: Aron Novak commented
FileSize
558028_not_add_default_mapping.patch5.4 KB

The file was missing :)

alex_b’s picture

alex_b CreditAttribution: alex_b commented

Could you explain _why_ #557512: Add default mapping for FEMP 2.x breaks tests and makes this patch necessary? Otherwise that's looking good.

Aron Novak’s picture

Aron Novak
Primary language Hungarian
Location Hungary, Budapest
CreditAttribution: Aron Novak commented

Yes, because it tries to add an already existing mapping, the option is not even the dropdown list. This definitely fails then.
Going to commit this patch.

Aron Novak’s picture

Aron Novak
Primary language Hungarian
Location Hungary, Budapest
CreditAttribution: Aron Novak commented
Status: Needs review » Fixed

committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.