If you visit the settings page and click 'save', empty proxy settings are stored in the database.
This causes the PHP soap library to assume you want to connect to a proxy host named "".

The attached patch checks uses NULL when value is saved but empty, so it behaves the same whether variables are absent from the database or empty empty strings.

CommentFileSizeAuthor
#1 soapclient_557748_2.diff1.87 KBilo
soapclient.module.diff933 bytesPeter Bex

Comments

ilo’s picture

ilo commented
Assigned: Unassigned » ilo
StatusFileSize
new soapclient_557748_2.diff1.87 KB

Hi Peter, thanks for the patch. I've improved a little bit to be sure that white space strings are also not allowed, and permit the string "0" (could be a username or password). PHP empty() function does not care about these two issues.

Peter Bex’s picture

Peter Bex commented

Thanks, this patch looks good.

*Wanders off, muttering something about PHP's typesystem*

ilo’s picture

ilo commented

Thanks, need to be tested before commiting. If as you said this could be a php error it may fail in some situations.

ilo’s picture

ilo commented
Title: After visiting settings page, all soap calls fail with "cannot connect to server" (with PHP5 SoapClient) » Incorrect usage of soapclient configuration strings
Status: Needs review » Fixed

Forget about this. I just have too many windows open and I did a mistake :)

Commited to 6.x-1.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.