Make standard roles translatable [#5570]

Comment	File	Size	Author
#18	translate_default_roles_1.patch	1.42 KB	killes@www.drop.org
#14	translate_default_roles_0.patch	1.81 KB	killes@www.drop.org
#11	translate_default_roles.patch	1.65 KB	killes@www.drop.org
#8	translate_default_roles.diff	1.84 KB	Cvbge

Comment #1

killes@www.drop.org commented 23 July 2004 at 17:19

Title:

Translation issues

» make standard roles translatable

Changing title.

Log in or register to post comments

Comment #2

Stefan Nagtegaal commented 6 October 2004 at 09:53

Component:	base system	» user system
Priority:	Normal	» Critical

This is still a problem.. The default roles 'Anonymous user' and 'Authenticated user' can not be translated.

Log in or register to post comments

Comment #3

axel commented 6 October 2004 at 12:55

But why this bug is critical? Drupal works on such manner long time. This bug don't prevent Drupal to work. I think priority of this bug must be set as 'normal', but not 'critical'.

Log in or register to post comments

I would say either committed to multilingual / localization or not. Calling it a feature seems to say "translation has a low priority". When that is the case, why all the trouble to localize? Jus drop localization and make life easier!

All depends on the chosen concept of Drupal. If you choose Drupal to be multilingual / localized, then this is definitely is a bug. You cannot expect a non-english speaker to understand these special users.

What happens when I just translate them in table role? Would it break Drupal?

Log in or register to post comments

Comment #6

schalker commented 4 May 2005 at 13:48

As I can tell, standard roles still can not be translated. Is this correct? Is there a work-around or some plan to implement this?

I'd agree with the former poster com2 that this is more a bug than a feature request: I love the locale module, but I cannot see a reason why almost everything is translateable, but not the standard roles. If there is no reason for this behaviour from a user-point-of-view, then this is a bug, I'd say.

Log in or register to post comments

Comment #7

schalker commented 4 May 2005 at 14:05

Category:

feature

» bug

Sorry, it's me again. I searched on and on to find a similar bug report, but I haven't found one. So as two people think this is a bug, I change the category of this issue back to "bug report".

Log in or register to post comments

Comment #8

Cvbge commented 9 August 2005 at 19:40

Status:

Active

» Needs review

Status	File	Size
new	translate_default_roles.diff	1.84 KB

Patch not tested, but it's quite simple. I'd like to hear some thoughts about t()ing default roles (anonymous and authenticated user).

Log in or register to post comments

Comment #9

Cvbge commented 9 August 2005 at 20:01

Status:

Needs review

» Needs work

Ok, this won't work, because roles are selected from db when put on admin/access.

The only way I see to solve this (although it's still not clean) is to
a) make default roles editable (so user can change the 'anonymous user' to something else), but not deletable
b) make sure anon user and auth user have static id
c) do not check in code for name, but for role id

Need to think about it...

Log in or register to post comments

Comment #10

Stefan Nagtegaal commented 24 August 2005 at 01:07

Indeed Cvbge.. Even in the latest CVS version 24-08-2005 this is still an issue..
It's the last 2 strings which could not be properly translated which really frustrates me, and hopefully other users..

Probably we can fix this issue when adding id's to the roles? Or by defining them as constants?

DEFINE('ANONYMOUS_USER', t('Anonymous user'));
DEFINE('AUTHENTICATED_USER', t('Authenticated user'));

The pro's of the defined constants method is that we can also get rid of the 'Anonymous user'-option on the settings page, because it becomes translatable..

What do you think, will this work?

Log in or register to post comments

Comment #11

killes@www.drop.org commented 31 January 2006 at 21:15

Assigned:	Unassigned	» killes@www.drop.org
Status:	Needs work	» Needs review

Status	File	Size
new	translate_default_roles.patch	1.65 KB

Here is a new attempt at this. Thanks to Moshe's patch this is now easy.

Log in or register to post comments

Comment #12

Stefan Nagtegaal commented 31 January 2006 at 22:01

Status:

Needs review

» Reviewed & tested by the community

Easy as peanutbutter!

Sorry Killes, I promissed todo this myself, but the lack of time held me away from this..

You rock! Thanks..

this is definitaly Ready To be committed!

Log in or register to post comments

Comment #13

dries commented 1 February 2006 at 14:31

Status:

Reviewed & tested by the community

» Needs work

Another patch invalidated this patch. Should be easy to fix. Thanks.

Log in or register to post comments

Comment #14

killes@www.drop.org commented 1 February 2006 at 14:31

Status:

Needs work

» Reviewed & tested by the community

Status	File	Size
new	translate_default_roles_0.patch	1.81 KB

Updated. Also initialize user->roles

Log in or register to post comments

Comment #15

killes@www.drop.org commented 1 February 2006 at 14:39

Status:

Reviewed & tested by the community

» Needs work

Doesn't work as is.

t() is not available so early in the request.

Log in or register to post comments

Comment #16

chx commented 9 February 2006 at 06:56

Title:

make standard roles translatable

» make standard roles and user names translatable

markus reports http://drupal.org/node/48198 that anonymous user name should be translatable. I think the two is so closely related that you need to roll them into one patch.

Log in or register to post comments

Comment #17

markus_petrux commented 9 February 2006 at 16:55

Though, while thinking how to translate roles (not easy atm, 'cause they are used before t() is ready), 'Anonymous' translation could be fixed.

Both are different things that may probably end up solved through 2 different patches. That's why I opened the other issue. You could focus on fixing the roles translation problem here.

Log in or register to post comments

Comment #18

killes@www.drop.org commented 12 February 2006 at 11:02

Title:	make standard roles and user names translatable	» make standard roles translatable
Status:	Needs work	» Needs review

Status	File	Size
new	translate_default_roles_1.patch	1.42 KB

The anon user name is different as there is a variable to change it.

Anyway, here is a new patch for the roles. It translates on output. extractor.php probably needs to be changed to add appropriate strings to user-module.pot.