Regions confusion ? [#555792]

Is there some confusion over regions in this theme ?

The .info file states that the following regions are available and these are what I see on the site building/blocks admin page :

regions[page_top] = Page top
regions[header] = Header
regions[left] = First sidebar
regions[right] = Second sidebar
regions[footer] = Footer
regions[page_bottom] = Page bottom

However the readme.txt files states that the following regions are available :

- Minimal regions : Header / Footer / content top / content bottom / 
sidebar left / sidebar right

The page.tpl.php file seems to me ( no expert ! ) to be outputing the set of regions described in the readme file rather than the .info file.

My specific problem is that manytimes ( nearly all times ? ) blocks are just not appearing in assigned regions except when I assign the Navigation block to the First sidebar.

Thanks for any pointers.

Dave

Comment	File	Size	Author
#7	Basic_blocks_page.png	51.3 KB	adam_b

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

El Bandito CreditAttribution: El Bandito commented 22 August 2009 at 09:22

Hi again

I've re-installed the theme and am still having the problem. It seems that the "Page top", "Footer", and "Page bottom" regions are not displaying their assigned blocks. I also notice that on the Site building/Blocks admin page the region indicators ( the yellow placeholders ) do not show for these 3 blocks. The other regions work fine.

Cheers

Dave

Comment #2

El Bandito CreditAttribution: El Bandito commented 22 August 2009 at 09:51

After a little more digging into how regions work it seems clear ( to me anyways ) that the .info file uses one set of names for the regions and then page.tpl.php tries to print regions with different names.

Fixable by updating page.tpl.php with the machine readable ( bracketed ) names from basic.info.

Dave

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 24 August 2009 at 20:49

Assigned:

Unassigned

The latest release of basic for d6 is a backport of some features of the drupal 7 version. You seam confused because you might have worked with a previous version of Basic, then updated to this one. Some markup change might be the cause of your problem.

The sidebar regions are still $left and $right, but for a more semantic output, the markup and css refers to them as "sidebar-first" and "sidebar-second". The CSS has been adapted as well.

I kept the value $left and $right because they are the drupal default regions. So I guess that the only thing you should change is your CSS.

I'd also point out that BASIC, unlike ZEN,is not intended to be used with a subtheme. It doesn't depend on a predefined theme, and is intended to be completely modified to its core. That's why it should stay as simple as possible. Therefor, it doesn't matter if your version of basic is outdated, and it's even not recommended to update to the latest version of basic when you already started to develop your custom theme with it.

Basic stops to be Basic as soon as you change the page.tpl.php or any other file of the theme.

Comment #4

Anonymous (not verified) CreditAttribution: Anonymous commented 24 August 2009 at 20:52

Status:

Active

» Needs review

Comment #5

adam_b CreditAttribution: adam_b commented 25 August 2009 at 14:17

subscribe - I'm having the same problem.

Comment #6

Anonymous (not verified) CreditAttribution: Anonymous commented 25 August 2009 at 23:40

Status:

Needs review

» Fixed

See message on project page or release notes

Comment #7

adam_b CreditAttribution: adam_b commented 26 August 2009 at 09:26

Version:	6.x-2.5	» 6.x-2.6
Status:	Fixed	» Needs review

File	Size
Basic_blocks_page.png	51.3 KB

The message refers to the sidebars, which are working fine. As Daves said in #1,

It seems that the "Page top", "Footer", and "Page bottom" regions are not displaying their assigned blocks. I also notice that on the Site building/Blocks admin page the region indicators ( the yellow placeholders ) do not show for these 3 blocks.

I've attached a screenshot of the /admin/build/block/list/basic page for a new, unmolested copy of Basic:
- the Header, First sidebar and Second sidebar regions are showing
- the Page top, Page bottom, and Footer regions are not showing

Comment #8

El Bandito CreditAttribution: El Bandito commented 26 August 2009 at 14:45

Couzinhub

Thanks for your response, but I don't think I've made myself clear. A few points :

1> I am using a fresh, un-altered instance of Basic v6.x-2.5. I can't comment on previous versions.

2> I have never used Basic ( or Zen for that matter ) before.

3> The page.tpl.php file does not print all the correct region names.

4> There is some confusion between whether the theme provides a "page_top" and "page_bottom" or a "content_top" and "content_bottom" ( in my mind these are quite different places on the viewport ). For example this excerpt from page.tpl.php :

<?php if ($page_bottom): ?>
            <div id="content-bottom">
              <?php print $page_bottom; ?>
            </div><!-- /#content-bottom -->
          <?php endif; ?>

confuses the 2 names.

I hope this helps in the spirit of constructive community !!!!

Cheers

Dave

Comment #9

Anonymous (not verified) CreditAttribution: Anonymous commented 26 August 2009 at 15:14

Category:	support	» bug
Priority:	Normal	» Critical
Status:	Needs review	» Active

OMG !!!

Guys, I'm so sorry ! I totally missed this, totally my fault ... :(
And not only I didn't see it, but also I can't seam to understand the problem when pointed out to me... apologies !

I got confused for a simple reason, I'm working on the Drupal 7 version quite a lot, and in Drupal 7, the content is now a block, so content top and bottom are not required anymore, as you can control the content position like a block.
That's why it didn't shock me when these two regions where gone from basic D6.

I'll update asap, and release 2.7

(wow, that a lot of release in just one month !)

Thanks for your sharp eyes guys !

Comment #10

Anonymous (not verified) CreditAttribution: Anonymous commented 26 August 2009 at 23:42

Version:	6.x-2.6	» 6.x-2.7
Priority:	Critical	» Normal
Status:	Active	» Fixed

Should be all good now !

2.7 is out.

Sorry again guys !

Comment #11

adam_b CreditAttribution: adam_b commented 27 August 2009 at 14:13

Version:

6.x-2.7

» 6.x-2.8

For anybody who's trying to update their theme based on Basic to make use of these fixes, the changes I've found are:

layout.css, changes from 2.4 to 2.6:
- line 34: #sidebar-left { becomes line 32: #sidebar-first {
- line 42: #sidebar-right { becomes line 40: #sidebar-second {

basic.info, changes from 2.6 to 2.8:
- line 8: regions[page_top] = Page top becomes regions[content_top] = Content top
- line 12: regions[footer] = Footer becomes regions[footer_block] = Footer
- line 13: regions[page_bottom] = Page bottom becomes regions[content_bottom] = Content bottom