Close, but not quite. Shouldn't remove query string apparently.

CommentFileSizeAuthor
#1 getBaseUrl-1.patch4.98 KBc960657

Comments

c960657’s picture

c960657 commented
Category: feature » bug
Status: Active » Needs review
StatusFileSize
new getBaseUrl-1.patch4.98 KB
joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented

I did a thorough code review and found no problems. In fact, I think the enhanced functionality looks a little sexier, so that's good.

Also, patch applied cleanly. Need to find someone who understands the implications of this patch to mark it RTBC.

Boombatower? If you like the direction, I would recommend you RTBC it.

Status: Needs review » Needs work

The last submitted patch failed testing.

c960657’s picture

c960657 commented
Status: Needs work » Needs review

Testbot glitch?

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Project: Drupal core » Browser
Version: 7.x-dev » 7.x-1.x-dev
Component: browser system » Code

Move to Browser module for further development.