Closed (won't fix)
Project:
Localization server
Version:
6.x-1.x-dev
Component:
l10n_localpacks
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
18 Aug 2009 at 19:39 UTC
Updated:
23 Sep 2015 at 18:44 UTC
Jump to comment: Most recent
Comments
Comment #1
gábor hojtsyGood idea.
However, I'd suggest not applying the same limit to the batch process like we do for the cron runs. The cron run is just one request and the batch process is as many requests as many packages we want to process, so we can have a much higher limit for the batch compared to the cron runs. Look at how I did a very similar solution in connectors/l10n_project.
Also, I'd suggest not to use the form submit function as an API function but instead just have an API function and reuse that from the form submit handler. Faking the form submission in the cron hook seems like a bad idea.
Finally, there are all kinds of whitespace issues. The start of l10n_localpacks_check_files() lacks whitespace, the l10n_localpacks_scan_batch_build() function has excessive whitespace and the phpdoc comments seem to only be stubs.
Comment #2
gábor hojtsyComment #3
SebCorbin commentedDo we still still need that now that 6.x is discontinued?
Comment #4
tobiasbNo. I do not use l10n_server anymore. And can not remember anymore what this is. :D