See patch.

CommentFileSizeAuthor
l10n_localpacks_batch_support.patch12.71 KBtobiasb

Comments

gábor hojtsy’s picture

Status: Needs review » Needs work

Good idea.

However, I'd suggest not applying the same limit to the batch process like we do for the cron runs. The cron run is just one request and the batch process is as many requests as many packages we want to process, so we can have a much higher limit for the batch compared to the cron runs. Look at how I did a very similar solution in connectors/l10n_project.

Also, I'd suggest not to use the form submit function as an API function but instead just have an API function and reuse that from the form submit handler. Faking the form submission in the cron hook seems like a bad idea.

Finally, there are all kinds of whitespace issues. The start of l10n_localpacks_check_files() lacks whitespace, the l10n_localpacks_scan_batch_build() function has excessive whitespace and the phpdoc comments seem to only be stubs.

gábor hojtsy’s picture

Title: Batch support for localpacks import » Add batch support for localpacks package parsing
Component: Code » l10n_localpacks
SebCorbin’s picture

Issue summary: View changes
Status: Needs work » Postponed (maintainer needs more info)

Do we still still need that now that 6.x is discontinued?

tobiasb’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)

No. I do not use l10n_server anymore. And can not remember anymore what this is. :D