broken l10n_community_user()

Good catch!

1. $category is still on the D6 API, so not sure why you removed it: http://api.drupal.org/api/function/hook_user/6 Granted, we do not use it, but it is part of the standard signature, so it is common to just include it anyway.

2. if ($op == 'view' && user_access(...)) would have been fine/shorter.

3. I'd put in the #type to the $items array, and then just assign that to the contributions item, so we do not need to iterate that again just to add the #type.

4. I'd love to commit the whitespace changes first, so if you can get that one separately (even if on this patch), then it would be easier for others to view what progress is made here.

Actually, I've committed an all-whitespace cleanup for the module, so I'm hopeful that you can reroll this patch with only the concrete changes. Please do.

- Hm, why wouldn't $row->language be set in any cases?
- You seem to add the top level keys to l10n_server_contributions for every row again and again.

As said above, I'd just fill up $items with the FAPI keys and then if (count($items)) { set up the top level l10n_server_contributions item and put $items below that as it is; }.

Thanks, committed!